Repository navigation
fix(gemini): map RECITATION finish reason to content_filtered - #4898
Open
charan-rathore wants to merge 1 commit into
Open
charan-rathore wants to merge 1 commit into
charan-rathore wants to merge 1 commit into
Conversation
Signed-off-by: Charan Rathore <180254320+charan-rathore@users.noreply.github.com>
liramon2
approved these changes
Oct 7, 2026
github-actions
Bot
added
complexity/low
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Gentle nudge - this is approved and CI is green. Anything else you need from me before it can merge? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4723
GeminiModelmappedfinishReason: RECITATIONtoend_turn, the same as an ordinarySTOP, so callers could not tell a normal completion from a response cut off for recitation.SAFETYalready maps to a distinct stop reason.This maps
RECITATIONtocontent_filtered, which is already a member of theStopReasontype ("Content was filtered due to policy violation"). Other Gemini finish reasons are unchanged.Testing
RECITATIONto the existing parametrizedtest_stream_response_without_usage_metadata. It fails on the old code and passes with the change.pytest tests/strands/models/test_gemini.py: 79 passed.ruff check,ruff format --checkandmypyon the touched files pass.Prepared with AI assistance (Claude Code).