Skip to content

Support adding icons from a provisioning URI 'image' parameter #1307

@RonOnGithub

Description

@RonOnGithub

Hi!

[I'm really glad you persisted through the hurdles the Play store threw in your path.
I was a bit horrified to see this no longer available while installing a new device until I discovered what they did you you and silently did to all the current users who installed the old package...]

Anyway, staying on topic, I was also glad to see support for importing custom icons - which means it would now be icing on the cake if users could more easily import them as part of provisioning a new service.

It seems wrong for me to be requesting you 'pollute' your included icon set with images for 'my' personal and group services that very few users will ever know about or access, but I can advertise them (and include them in a provisioning QR code) for people who do with something like:

https://github.com/Spomky-Labs/otphp/blob/11.4.x/doc/Customize.md#image

Which can be/is used by roundcube and similar services, so this feature is widely applicable to anyone self-hosting and using 2FA.

I get that you don't want to add network access to this (and it makes me really happy to see you avoiding scope creep in that way!), but it should be enough to just display the image resource URL in a way that can be clicked on or copied to the clipboard, so the user can then download it themselves and add it from there.

Anyway thanks again for your work on this - more than just being reliable and useful, it's a shining light of best practice that others would do well to learn from and emulate.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions