Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding in table heading cells. Please think about it once again 🙏 #7498

Open
Starship-Headlight opened this issue Feb 6, 2025 · 2 comments · May be fixed by #7553
Open

Padding in table heading cells. Please think about it once again 🙏 #7498

Starship-Headlight opened this issue Feb 6, 2025 · 2 comments · May be fixed by #7553
Labels
Platform: All Status: Confirmed Bug is confirmed but work on a fix hasn't yet started. Unit: Editor Issues related to the editor

Comments

@Starship-Headlight
Copy link

Starship-Headlight commented Feb 6, 2025

What problem are you facing?

Before v3 came out around v2.5 the grey padding in table heading cells was removed. Below is a screenshot from Notesnook website:

Image

The grey padding had a special feature. It doesn't change with the change of theme. I have tried many background colors and none of them work like that. It becomes an issue when changing the themes.

For example, if you make a cell with black background, it is fine with dark theme. However, if you change the theme to light theme, the dark color of the text makes the text illegible.

This was a feature I used many many times in my workflow while handling tables. I deal with a lot of tables and changing background for heading cells after changing a theme becomes a hassle. If not by default, please at least add an option to do this again.

What's the solution you'd like to see in Notesnook?

Maybe restore the code or add an option for this in the cell edit options. It's just an extra feature. If someone doesn't like the heading padding, they can just remove the first row in the table. That's it.

@Starship-Headlight
Copy link
Author

I think it used to change like this:

Dark mode :- 2b2b2b
Light mode :- f7f7f7

I am not sure about this as I just used windows color picker from some old notes I had exported in PDF from the previous versions of notesnook.

Maybe looking at the old code will make it more apparent.

@Starship-Headlight
Copy link
Author

Starship-Headlight commented Feb 10, 2025

So I was able to get these screenshots from v2.4.4. The headings changing with themes

Dark theme
Image

Light theme

Image

@01zulfi 01zulfi added Unit: Editor Issues related to the editor Status: Confirmed Bug is confirmed but work on a fix hasn't yet started. Platform: All labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: All Status: Confirmed Bug is confirmed but work on a fix hasn't yet started. Unit: Editor Issues related to the editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants