Eslint import (firefox-devtools#5315)

Author: gregtatum

.eslintrc

@@ -1,6 +1,6 @@
 {
   "parser": "babel-eslint",
-  "plugins": ["react", "mozilla", "flowtype", "babel", "prettier"],
+  "plugins": ["react", "mozilla", "flowtype", "babel", "prettier", "import"],
   "globals": {
     "atob": true,
     "btoa": true,
@@ -70,6 +70,12 @@
       }
     ],
 
+    // Check for import errors.
+    "import/no-duplicates": "error",
+    "import/no-unresolved": "error",
+    "import/named": "error",
+    "import/export": "error",
+
     // Enforce the spacing around the * in generator functions.
     "generator-star-spacing": [2, "after"],
 

bin/eslint-import-resolver.js

@@ -365,14 +365,14 @@ type ExpressionState = {
   expressions: List<Expression>
 };
 
-export const State = makeRecord(
+export const createExpressionState = makeRecord(
   ({
     expressions: List()
   }: ExpressionState)
 );
 
 function update(
-  state: Record<ExpressionState> = State(),
+  state: Record<ExpressionState> = createExpressionState(),
   action: Action
 ): Record<ExpressionState> {
   // ...
@@ -411,14 +411,14 @@ type ExpressionState = {
   expressions: List<Expression>
 };
 
-export const State = makeRecord(
+export const createExpressionState = makeRecord(
   ({
     expressions: List()
   }: ExpressionState)
 );
 
 function update(
-  state: Record<ExpressionState> = State(),
+  state: Record<ExpressionState> = createExpressionState(),
   action: Action
 ): Record<ExpressionState> {
   case "DELETE_EXPRESSION":

docs/local-development.md

@@ -77,6 +77,7 @@
     "devtools-source-map": "^0.14.7",
     "devtools-splitter": "^0.0.6",
     "devtools-utils": "^0.0.10",
+    "eslint-plugin-import": "^2.8.0",
     "fuzzaldrin-plus": "^0.6.0",
     "immutable": "^3.8.2",
     "lodash": "^4.17.4",

flow-typed/debugger-html.js

@@ -19,7 +19,7 @@ import {
   getFramework
 } from "../workers/parser";
 
-import type { SourceId } from "debugger-html";
+import type { SourceId } from "../types";
 import type { ThunkArgs } from "./types";
 
 export function setSourceMetaData(sourceId: SourceId) {

package.json

@@ -5,10 +5,7 @@
 import { getOutOfScopeLocations, getSelectedSource } from "../../selectors";
 import { getSourceLineCount } from "../../utils/source";
 
-import { range } from "lodash";
-import { flatMap } from "lodash";
-import { uniq } from "lodash";
-import { without } from "lodash";
+import { range, flatMap, uniq, without } from "lodash";
 
 function getOutOfScopeLines(outOfScopeLocations: AstLocation[]) {
   if (!outOfScopeLocations) {