Skip to content

Commit ed87d97

Browse files
committed
Fix language server cannot start if Julia was installed via juliaup
Disable the presence check of the Julia executable for now, because shutil.which doesn't support symlinks on Python 3.3 on Windows.
1 parent 05db5ab commit ed87d97

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

plugin.py

+9-4
Original file line numberDiff line numberDiff line change
@@ -605,10 +605,15 @@ def server_version(cls) -> str:
605605

606606
@classmethod
607607
def needs_update_or_installation(cls) -> bool:
608-
if not shutil.which(cls.julia_exe()):
609-
msg = ('The executable "{}" could not be found. Set up the path to the Julia executable by running the '
610-
'command\n\n\tPreferences: LSP-julia Settings\n\nfrom the command palette.').format(cls.julia_exe())
611-
raise RuntimeError(msg)
608+
# The check for presence of the julia executable is disabled for now, because
609+
# [`shutil.which`](https://docs.python.org/release/3.3.6/library/shutil.html#shutil.which) doesn't work with
610+
# symlinks on Python 3.3 (on Windows at least), and if Julia was installed via juliaup it will create a symlink
611+
# for it - see https://github.com/sublimelsp/LSP-julia/issues/24
612+
#
613+
# if not shutil.which(cls.julia_exe()):
614+
# msg = ('The executable "{}" could not be found. Set up the path to the Julia executable by running the '
615+
# 'command\n\n\tPreferences: LSP-julia Settings\n\nfrom the command palette.').format(cls.julia_exe())
616+
# raise RuntimeError(msg)
612617
try:
613618
with open(cls.version_file(), "r") as fp:
614619
return cls.server_version() != fp.read().strip()

0 commit comments

Comments
 (0)