-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Cleanup: Organising folder structure into frontend, backend and README #82
Comments
👋 Thank you for raising an issue! We appreciate your effort in helping us improve. Our team will review it shortly. Stay tuned! |
@jinx-vi-0 Do you mind setting up relevant labels and assigning it to me? Although I have some experience in dev, It's always been solo projects, never really open source. Looking forward to do my best here! |
Okay, sounds good! Just make sure to check every endpoint and configuration to ensure everything works perfectly. Also, please update the README to reflect any changes you make. Looking forward to your contributions! |
Will do! @jinx-vi-0 |
Yeah, add the .env to gitignore and create an example.env to help contributors understand the .env structure. |
@jinx-vi-0 is there any issue with the export option? It doesn't seem to work. I reverted all my changes, but it still seems to not respond? |
@jinx-vi-0 The download doesn't happen cause of the following reason. In server.js, This expects id as a parameter. Which means anything after "http://localhost:3000/" will be seen as the id parameter. Hence when we try to export passwords, it is unable to reach the handler: Leading to error. Check it out yourself. Once you comment out the /:id handler, the export option works. This is a major backend flaw. Would you like me to make an issue for the same? |
@pranavajith create an issue. I'll assign it to you. |
Hi, @pranavajith what's the progress status on this issue? |
Marked as Up-To-Grab since there's no update yet. |
@jinx-vi-0 Could you please assign this to me? I’ve been exploring open source projects, and I’ll do my best to contribute and resolve it. |
Is your feature request related to a problem? Please describe.
The README.md seems to indicate that the folder structure is as follows
PassOP/
├── backend/ # Backend Node.js application
│ ├── server.js # Main server file
│ ├── .env # Environment configuration (not included in repo)
│ ├── package.json # Backend dependencies
│ └── ... # Other backend files
├── frontend/ # React frontend application (using Vite)
│ ├── src/ # React components and files
│ ├── public/ # Public static files
│ ├── package.json # Frontend dependencies
│ └── vite.config.js # Vite configuration file
├── README.md # This file
└── ...
Whereas, currently that is not the case. This caused me a lot of confusion initially, and I'd imagine it is the same for many people.
Describe the solution you'd like
I would like to first organise the files into frotnend and backend folder, and then update the README to match this.
Describe alternatives you've considered
We could simply change the README to fit the current structure,, but the current structure is not the most widely seen uniform seperation of concerns of frontend and backend, and so it is not ideal.
Additional context
Will add any that is needed by admin. As of now, seems self explanatory.
The text was updated successfully, but these errors were encountered: