Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for both ESM and CJS #19

Closed
farazatarodi opened this issue Mar 30, 2025 · 3 comments
Closed

Build for both ESM and CJS #19

farazatarodi opened this issue Mar 30, 2025 · 3 comments

Comments

@farazatarodi
Copy link

Chore

Describe the chore

The npm bundle uses the source ESM files directly. Providing both CJS and ESM builds for maximum compatibility in the vast JS ecosystem would be nice.

Additional context

I suggest two changes:

  • Convert the source files to Typescript (To generate the index.d.ts file automatically).
  • Configure the project to build for both ESM and CJS.

I would be happy to help with a PR.

@farazatarodi
Copy link
Author

Extra context:
I came across this topic due to this bug in Nx: nrwl/nx#11335

I was about to fork this repo and patch it for my project, but I thought maybe I could contribute to Supabase as a token of appreciation.

@kamilogorek
Copy link
Contributor

Hey @farazatarodi, thanks for the report. Just wanted to let you know that this package will be most likely deprecated beeeecause Sentry decided to move it into the core itself! :)
getsentry/sentry-javascript#15719

@farazatarodi
Copy link
Author

@kamilogorek Thanks for the reply!
I'm glad to see this is getting some love. I will wait for the new update then 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants