fix(start): make storage seeding respect db.seed.enabled with --no-seed override

Author: MuzzaiyyanHussain

internal/start/start.go

@@ -249,9 +249,6 @@ func run(ctx context.Context, fsys afero.Fs, excludedContainers []string, dbConf
 		utils.Config.Storage.ImageTransformation.Enabled && !isContainerExcluded(utils.Config.Storage.ImgProxyImage, excluded)
 	isS3ProtocolEnabled := utils.Config.Storage.S3Protocol != nil && utils.Config.Storage.S3Protocol.Enabled
 	fmt.Fprintln(os.Stderr, "Starting containers...")
-	if skipSeed {
-	fmt.Fprintln(os.Stderr, "Skipping storage seeding (--no-seed enabled)")
-}
 	workdir, err := os.Getwd()
 	if err != nil {
 		return errors.Errorf("failed to get working directory: %w", err)
@@ -1280,19 +1277,23 @@ EOF
 	}
 
 	fmt.Fprintln(os.Stderr, "Waiting for health checks...")
+
 	if utils.NoBackupVolume && slices.Contains(started, utils.StorageId) {
 		if err := start.WaitForHealthyService(ctx, serviceTimeout, utils.StorageId); err != nil {
 			return err
 		}
-		// Disable prompts when seeding
-			if skipSeed {
-		fmt.Fprintln(os.Stderr, "Skipping storage seeding (--no-seed enabled)")
-	} else {
-		// Disable prompts when seeding
-		if err := buckets.Run(ctx, "", false, fsys); err != nil {
-			return err
+
+		// Follow db.seed.enabled by default, allow --no-seed as override
+		if skipSeed {
+			fmt.Fprintln(os.Stderr, "Skipping storage seeding (--no-seed enabled)")
+		} else if !utils.Config.Db.Seed.Enabled {
+			fmt.Fprintln(os.Stderr, "Skipping storage seeding (db.seed.enabled = false)")
+		} else {
+			if err := buckets.Run(ctx, "", false, fsys); err != nil {
+				return err
+			}
 		}
-	}
+
 	}
 	return start.WaitForHealthyService(ctx, serviceTimeout, started...)
 }

internal/start/start_test.go

@@ -253,6 +253,97 @@ func TestDatabaseStart(t *testing.T) {
 		assert.NoError(t, err)
 		assert.Empty(t, apitest.ListUnmatchedRequests())
 	})
+
+	t.Run("skips storage seeding when db.seed.enabled is false", func(t *testing.T) {
+		utils.Config.Analytics.Enabled = false
+		utils.Config.Api.Enabled = false
+		utils.Config.Auth.Enabled = false
+		utils.Config.Realtime.Enabled = false
+		utils.Config.Studio.Enabled = false
+		utils.Config.EdgeRuntime.Enabled = false
+		utils.Config.Inbucket.Enabled = false
+		utils.Config.Db.Pooler.Enabled = false
+
+		fsys := afero.NewMemMapFs()
+
+		// Restore global state
+		origSeed := utils.Config.Db.Seed.Enabled
+		t.Cleanup(func() {
+			utils.Config.Db.Seed.Enabled = origSeed
+		})
+		utils.Config.Db.Seed.Enabled = false
+
+		require.NoError(t, apitest.MockDocker(utils.Docker))
+		defer gock.OffAll()
+
+		gock.New(utils.Docker.DaemonHost()).
+			Head("/_ping").
+			Reply(http.StatusOK)
+
+		gock.New(utils.Docker.DaemonHost()).
+			Post("/v" + utils.Docker.ClientVersion() + "/networks/create").
+			Reply(http.StatusCreated).
+			JSON(network.CreateResponse{})
+
+		// 🔑 REQUIRED: cache all images
+		for _, img := range config.Images.Services() {
+			service := utils.GetRegistryImageUrl(img)
+			gock.New(utils.Docker.DaemonHost()).
+				Get("/v" + utils.Docker.ClientVersion() + "/images/" + service + "/json").
+				Reply(http.StatusOK).
+				JSON(image.InspectResponse{})
+		}
+
+		// ALSO mock postgres image (DB is not part of Services())
+		dbImage := utils.GetRegistryImageUrl(utils.Config.Db.Image)
+		gock.New(utils.Docker.DaemonHost()).
+			Get("/v" + utils.Docker.ClientVersion() + "/images/" + dbImage + "/json").
+			Reply(http.StatusOK).
+			JSON(image.InspectResponse{})
+
+		utils.DbId = "test-postgres"
+		utils.Config.Db.Port = 54322
+		utils.Config.Db.MajorVersion = 15
+
+		gock.New(utils.Docker.DaemonHost()).
+			Get("/v" + utils.Docker.ClientVersion() + "/volumes/" + utils.DbId).
+			Reply(http.StatusOK).
+			JSON(volume.Volume{})
+
+		apitest.MockDockerStart(
+			utils.Docker,
+			utils.GetRegistryImageUrl(utils.Config.Db.Image),
+			utils.DbId,
+		)
+
+		gock.New(utils.Docker.DaemonHost()).
+			Get("/v" + utils.Docker.ClientVersion() + "/containers/" + utils.DbId + "/json").
+			Reply(http.StatusOK).
+			JSON(container.InspectResponse{
+				ContainerJSONBase: &container.ContainerJSONBase{
+					State: &container.State{
+						Running: true,
+						Health:  &container.Health{Status: types.Healthy},
+					},
+				},
+			})
+		exclude := []string{
+			utils.ShortContainerImageName(utils.Config.Api.KongImage),
+			utils.ShortContainerImageName(utils.Config.Storage.Image),
+		}
+
+		err := run(
+			context.Background(),
+			fsys,
+			exclude,
+			pgconn.Config{Host: utils.DbId},
+			false,
+		)
+
+		assert.NoError(t, err)
+		assert.Empty(t, apitest.ListUnmatchedRequests())
+	})
+
 }
 
 func TestFormatMapForEnvConfig(t *testing.T) {