test: show requests/batch_size on loadtest report

Author: steve-chavez

nix/loadtest.nix

@@ -78,7 +78,7 @@ writeShellScriptBin "net-loadtest" ''
   fi
 
   net-with-nginx xpg --options "-c log_min_messages=WARNING $batch_size_opt" \
-    psql -c "call wait_for_many_gets($reqs)" -c "\pset format csv" -c "\o $query_csv" -c "select * from pg_net_stats" > /dev/null &
+    psql -c "call wait_for_many_gets($reqs)" -c "\pset format csv" -c "\o $query_csv" -c "select * from run" > /dev/null &
 
   # wait for process to start so we can capture it with psrecord
   sleep 2

test/utils/loadtest.sql

@@ -1,20 +1,22 @@
-create table time_taken (time_taken interval);
-
-create view pg_net_stats as
-select
-  count(*) filter (where error_msg is null) as request_successes,
-  count(*) filter (where error_msg is not null) as request_failures,
-  (select error_msg from net._http_response where error_msg is not null order by id desc limit 1) as last_failure_error,
-  (select time_taken from time_taken limit 1) as time_taken
-from net._http_response;
+create table run (
+  requests int,
+  batch_size int,
+  time_taken interval,
+  request_successes bigint,
+  request_failures bigint,
+  last_failure_error text
+);
 
 -- loadtest using many gets, used to be called `repro_timeouts`
 create or replace procedure wait_for_many_gets(number_of_requests int default 10000, url text default 'http://localhost:8080') as $$
 declare
   last_id bigint;
   first_time timestamptz;
   second_time timestamptz;
-  time_taken interval;
+
+  request_successes bigint;
+  request_failures bigint;
+  last_failure_error text;
 begin
   delete from net._http_response;
 
@@ -33,8 +35,15 @@ begin
 
   select clock_timestamp() into second_time;
 
-  select age(second_time, first_time) into time_taken;
+  select
+    count(*) filter (where error_msg is null),
+    count(*) filter (where error_msg is not null),
+    (select error_msg from net._http_response where error_msg is not null order by id desc limit 1)
+  into request_successes, request_failures, last_failure_error
+  from net._http_response;
 
-  insert into time_taken values (time_taken);
+  insert into run values (
+    number_of_requests, current_setting('pg_net.batch_size')::int, age(second_time, first_time),
+    request_successes, request_failures, last_failure_error);
 end;
 $$ language plpgsql;