Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Create config-parseable Prefixes type #3701

Open
tsmethurst opened this issue Jan 27, 2025 · 0 comments
Open

[chore] Create config-parseable Prefixes type #3701

tsmethurst opened this issue Jan 27, 2025 · 0 comments
Assignees
Milestone

Comments

@tsmethurst
Copy link
Contributor

i think in terms of getting v0.18.0 out, this looks good to go 👍 . but ideally instead of storing an extra ___Parsed field type we should instead just have a type that instead supports automatic unparsing otherwise it's just adding to our already cluttered config struct. i think wrapping the []netip.Prefix type to specifically support some kind of text unmarshaler interface will probably do the trick.

but before squerging this would you be able to make an issue to clean that up, and then once v0.18.0 is out get on it just so it doesn't get burried under our large tech-debt pile? :P

Originally posted by @NyaaaWhatsUpDoc in #3699 (comment)

@tsmethurst tsmethurst added this to the v0.19.0 milestone Jan 27, 2025
@tsmethurst tsmethurst self-assigned this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant