templates: forbid '/' in customer names + add by-name lookup#45
Draft
meAmitPatil wants to merge 1 commit into
Draft
templates: forbid '/' in customer names + add by-name lookup#45meAmitPatil wants to merge 1 commit into
meAmitPatil wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related changes that close the namespace squat hole and give SDKs a clean name lookup path.
1. Forbid
/in customer template names. Today the regex allows it but we only blocked thesuperserve/prefix specifically. A customer could still createsystem/foo,e2b/bar, etc. — names that look platform-curated. Now/is rejected for all non-system teams.2. Add
GET /templates/names/{name}. Dedicated lookup endpoint for resolving a template by name to a single object (200/404), mirroringGET /templates/{template_id}but keyed on name. Wildcard route handles the slash in system template names (superserve/python-3.11).Notes
/). All existing customer templates are flat anyway, so no migration needed.superserve/...namespacing.patternon the create-templatenamefield tightened to drop/(matches what customers can submit).