Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page embeds font stylesheet from redhat.com #59

Open
ghost opened this issue Jul 29, 2021 · 2 comments
Open

Page embeds font stylesheet from redhat.com #59

ghost opened this issue Jul 29, 2021 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 29, 2021

I see https://static.redhat.com/libs/redhat/redhat-font/2/webfonts/red-hat-font.css being loaded by the page. It's also trying to load RH's Overpass font from fonts.googleapis.com.

@ghost ghost changed the title Page embeds a font from redhat.com Page embeds font stylesheet from redhat.com Jul 29, 2021
@oskapt
Copy link
Contributor

oskapt commented Aug 12, 2021

Where do you see this? I'm looking in the entire page source, and there's nothing that says "static.redhat.com."

@ghost
Copy link
Author

ghost commented Aug 13, 2021

So I saw it in uBlock first, but also in the devtools.

Firefox dev tools, network panel ![Firefox dev tools, network panel](https://user-images.githubusercontent.com/5476547/129343029-3093f4a2-d6b6-43b6-a1ea-dc6eeedd79f3.png)

It appears to come out of the SASS source, specifically, the unnecessary font embeds here:

@import url("https://fonts.googleapis.com/css?family=Overpass:300,400,800");
@import url("https://static.redhat.com/libs/redhat/redhat-font/2/webfonts/red-hat-font.css");

and:

@import url("https://fonts.googleapis.com/css?family=Overpass:300,400,800");
@import url("https://static.redhat.com/libs/redhat/redhat-font/2/webfonts/red-hat-font.css");

And there's an unnecessary default font definition here (which I think is overwritten by your custom stylesheets):

$base-font-family: "RedHatText", "Overpass", Overpass, Helvetica, helvetica, arial, sans-serif;
$base-font-family--heading: "RedHatDisplay", "Overpass", Overpass, Helvetica, helvetica, arial, sans-serif;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant