Skip to content

Commit 4463dde

Browse files
committed
chore: add comments to explain changes
1 parent b58e013 commit 4463dde

File tree

4 files changed

+6
-0
lines changed

4 files changed

+6
-0
lines changed

.github/workflows/NodeCI.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ env:
1111

1212
defaults:
1313
run:
14+
# Setting every runner to bash simplifies command calls;
15+
# plus, every platform supports it
1416
shell: bash
1517

1618
jobs:

packages/eslint-plugin-svelte/src/rules/no-unused-props.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ export default createRule('no-unused-props', {
123123
const declarations = symbol.getDeclarations();
124124
if (!declarations || declarations.length === 0) return false;
125125

126+
// TypeScript declaration file name is normalized to support Windows style paths
126127
return declarations.every((decl) => normalize(decl.getSourceFile().fileName) === fileName);
127128
}
128129

packages/eslint-plugin-svelte/src/rules/valid-style-parse.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ export default createRule('valid-style-parse', {
2323
SvelteStyleElement(node) {
2424
const styleContext = sourceCode.parserServices.getStyleContext!();
2525
if (styleContext.status === 'parse-error') {
26+
// This will replace backslashes to forward slashes only
27+
// if Node.js reports Windows style path separators
2628
let message = styleContext.error.message.replace(cwd, '');
2729
if (path.sep === '\\') message = message.replace(/\\/g, '/');
2830

packages/eslint-plugin-svelte/tests/utils/utils.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,7 @@ function writeFixtures(
305305
}
306306

307307
function getConfig(ruleName: string, inputFile: string) {
308+
// ruleName is normalized to support Windows style paths
308309
const filename = inputFile.slice(inputFile.indexOf(path.normalize(ruleName)));
309310
const code = fs.readFileSync(inputFile, 'utf8');
310311
let config;

0 commit comments

Comments
 (0)