feat: limiting more rules to prevent false positives (#1299)

Author: marekdedic

.changeset/quick-forks-hear.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-svelte': patch
+---
+
+feat: disabling more rules in runes mode

.changeset/rude-suns-send.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-svelte': patch
+---
+
+feat: restricting SvelteKit rules to SvelteKit

packages/eslint-plugin-svelte/src/rules/experimental-require-slot-types.ts

@@ -14,7 +14,16 @@ export default createRule('experimental-require-slot-types', {
 		messages: {
 			missingSlotsInterface: `The component must define the $$Slots interface.`
 		},
-		type: 'suggestion'
+		type: 'suggestion',
+		conditions: [
+			{
+				svelteVersions: ['3/4']
+			},
+			{
+				svelteVersions: ['5'],
+				runes: [false, 'undetermined']
+			}
+		]
 	},
 	create(context) {
 		let isTs = false;

packages/eslint-plugin-svelte/src/rules/experimental-require-strict-events.ts

@@ -16,7 +16,12 @@ export default createRule('experimental-require-strict-events', {
 		messages: {
 			missingStrictEvents: `The component must have the strictEvents attribute on its <script> tag or it must define the $$Events interface.`
 		},
-		type: 'suggestion'
+		type: 'suggestion',
+		conditions: [
+			{
+				svelteVersions: ['3/4']
+			}
+		]
 	},
 	create(context) {
 		let isTs = false;

packages/eslint-plugin-svelte/src/rules/no-extra-reactive-curlies.ts

@@ -15,7 +15,16 @@ export default createRule('no-extra-reactive-curlies', {
 			extraCurlies: `Do not wrap reactive statements in curly braces unless necessary.`,
 			removeExtraCurlies: `Remove the unnecessary curly braces.`
 		},
-		type: 'suggestion'
+		type: 'suggestion',
+		conditions: [
+			{
+				svelteVersions: ['3/4']
+			},
+			{
+				svelteVersions: ['5'],
+				runes: [false, 'undetermined']
+			}
+		]
 	},
 	create(context) {
 		return {

packages/eslint-plugin-svelte/src/rules/no-goto-without-base.ts

@@ -18,7 +18,12 @@ export default createRule('no-goto-without-base', {
 			isNotPrefixedWithBasePath:
 				"Found a goto() call with a url that isn't prefixed with the base path."
 		},
-		type: 'suggestion'
+		type: 'suggestion',
+		conditions: [
+			{
+				svelteKitVersions: ['1.0.0-next', '1', '2']
+			}
+		]
 	},
 	create(context) {
 		return {

packages/eslint-plugin-svelte/src/rules/no-immutable-reactive-statements.ts

@@ -16,7 +16,16 @@ export default createRule('no-immutable-reactive-statements', {
 			immutable:
 				'This statement is not reactive because all variables referenced in the reactive statement are immutable.'
 		},
-		type: 'suggestion'
+		type: 'suggestion',
+		conditions: [
+			{
+				svelteVersions: ['3/4']
+			},
+			{
+				svelteVersions: ['5'],
+				runes: [false, 'undetermined']
+			}
+		]
 	},
 	create(context) {
 		const scopeManager = context.sourceCode.scopeManager;

packages/eslint-plugin-svelte/src/rules/no-navigation-without-base.ts

@@ -44,7 +44,12 @@ export default createRule('no-navigation-without-base', {
 			replaceStateNotPrefixed:
 				"Found a replaceState() call with a url that isn't prefixed with the base path."
 		},
-		type: 'suggestion'
+		type: 'suggestion',
+		conditions: [
+			{
+				svelteKitVersions: ['1.0.0-next', '1', '2']
+			}
+		]
 	},
 	create(context) {
 		let basePathNames: Set<TSESTree.Identifier> = new Set<TSESTree.Identifier>();

packages/eslint-plugin-svelte/tests/fixtures/rules/experimental-require-strict-events/invalid/_requirements.json

@@ -0,0 +1,3 @@
+{
+	"svelte": "^4"
+}

packages/eslint-plugin-svelte/tests/fixtures/rules/experimental-require-strict-events/valid/_requirements.json

@@ -0,0 +1,3 @@
+{
+	"svelte": "^4"
+}