Skip to content

Commit b5000df

Browse files
fix: ensure cache key is consistent between client/server (#14563)
fixes #14562 Use same function to generate cache keys for remote query data during ssr and hydration so the logic doesn't need to be duplicated.
1 parent 1fdc800 commit b5000df

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

.changeset/dry-ideas-ring.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@sveltejs/kit': patch
3+
---
4+
5+
fix: ensure cache key is consistent between client/server

packages/kit/src/runtime/app/server/remote/query.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,10 @@ export function query(validate_or_fn, maybe_fn) {
9090
);
9191
}
9292

93-
const cache = get_cache(__, state);
94-
const key = stringify_remote_arg(arg, state.transport);
95-
9693
if (__.id) {
97-
refreshes[__.id + '/' + key] = cache[key] = Promise.resolve(value);
94+
const cache = get_cache(__, state);
95+
const key = stringify_remote_arg(arg, state.transport);
96+
refreshes[create_remote_cache_key(__.id, key)] = cache[key] = Promise.resolve(value);
9897
}
9998
};
10099

packages/kit/src/runtime/server/page/render.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import { add_resolution_suffix } from '../../pathname.js';
1616
import { with_request_store } from '@sveltejs/kit/internal/server';
1717
import { text_encoder } from '../../utils.js';
1818
import { get_global_name } from '../utils.js';
19+
import { create_remote_cache_key } from '../../shared.js';
1920

2021
// TODO rename this function/module
2122

@@ -493,7 +494,7 @@ export async function render_response({
493494
if (!info.id) continue;
494495

495496
for (const key in cache) {
496-
remote[key ? info.id + '/' + key : info.id] = await cache[key];
497+
remote[create_remote_cache_key(info.id, key)] = await cache[key];
497498
}
498499
}
499500

0 commit comments

Comments
 (0)