Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CF Pages PR (#5453) incorrect #5575

Closed
isaac-mcfadyen opened this issue Jul 17, 2022 · 0 comments · Fixed by #5576
Closed

CF Pages PR (#5453) incorrect #5575

isaac-mcfadyen opened this issue Jul 17, 2022 · 0 comments · Fixed by #5576

Comments

@isaac-mcfadyen
Copy link
Contributor

Describe the bug

In the recent PR (#5453) it was stated that, in order to make _headers and _redirects work you need to add them to the /static directory.

However, these files do not work with _worker.js.

I confirmed this with a Cloudflare Pages employee, who said that it's up to the framework or other platform bundling the _worker.js to handle these, as they are normally injected during the Functions build step which is overriden with _worker.js.

Since this information is incorrect it should be removed.

Reproduction

N/A

Logs

N/A

System Info

N/A

Severity

annoyance

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant