Skip to content

Commit f49db0f

Browse files
authored
Handle missing export error (#119)
* handle missing package.json export * ignore dupes * tweak formatting * reword * reword * do not check for existence
1 parent 97dbb86 commit f49db0f

File tree

7 files changed

+42
-0
lines changed

7 files changed

+42
-0
lines changed

index.js

+11
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ const { createFilter } = require('rollup-pluginutils');
66
const { encode, decode } = require('sourcemap-codec');
77

88
const major_version = +version[0];
9+
const pkg_export_errors = new Set();
910

1011
const { compile, preprocess } = major_version >= 3
1112
? require('svelte/compiler.js')
@@ -50,6 +51,10 @@ function tryResolve(pkg, importer) {
5051
return relative.resolve(pkg, importer);
5152
} catch (err) {
5253
if (err.code === 'MODULE_NOT_FOUND') return null;
54+
if (err.code === 'ERR_PACKAGE_PATH_NOT_EXPORTED') {
55+
pkg_export_errors.add(pkg.replace(/\/package.json$/, ''));
56+
return null;
57+
}
5358
throw err;
5459
}
5560
}
@@ -334,7 +339,13 @@ module.exports = function svelte(options = {}) {
334339
}, this.warn);
335340

336341
css(writer);
342+
343+
337344
}
345+
if (pkg_export_errors.size < 1) return;
346+
347+
console.warn('\nrollup-plugin-svelte: The following packages did not export their `package.json` file so we could not check the `svelte` field. If you had difficulties importing svelte components from a package, then please contact the author and ask them to export the package.json file.\n');
348+
console.warn(Array.from(pkg_export_errors).map(s => `- ${s}`).join('\n') + '\n');
338349
}
339350
};
340351
};

test/node_modules/esm-component/index.js

Whitespace-only changes.

test/node_modules/esm-component/package.json

+8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/node_modules/esm-component/src/Component.svelte

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/node_modules/esm-no-pkg-export/index.js

Whitespace-only changes.

test/node_modules/esm-no-pkg-export/package.json

+6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/test.js

+16
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,22 @@ describe('rollup-plugin-svelte', () => {
3333
);
3434
});
3535

36+
it('ignores esm modules that do not export package.json', () => {
37+
const { resolveId } = plugin();
38+
assert.equal(
39+
resolveId('esm-no-pkg-export', path.resolve('test/foo/main.js')),
40+
null
41+
);
42+
});
43+
44+
it('resolves esm module that exports package.json', () => {
45+
const { resolveId } = plugin();
46+
assert.equal(
47+
resolveId('esm-component', path.resolve('test/foo/main.js')),
48+
path.resolve('test/node_modules/esm-component/src/Component.svelte')
49+
);
50+
});
51+
3652
it('ignores virtual modules', () => {
3753
const { resolveId } = plugin();
3854
assert.equal(

0 commit comments

Comments
 (0)