Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore typescript abstract methods during code transformation #15267

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

caiquetorres
Copy link
Contributor

Problem

When transforming TypeScript code, abstract methods were incorrectly included in the generated JavaScript output. Given the following TypeScript code:

abstract class MyClass {
    abstract myMethod(): void;
}

The transformation produced invalid JavaScript:

class MyClass {
    myMethod()
}

This resulted in a syntax error in the browser.

Solution

This PR ensures that abstract methods are removed during transformation, so the output JavaScript becomes:

class MyClass {}

Resolves #15260

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: 4723578

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15267

@dummdidumm
Copy link
Member

Thank you, but we should instead strip that AST node completely within https://github.com/sveltejs/svelte/blob/main/packages/svelte/src/compiler/phases/1-parse/remove_typescript_nodes.js - that way we don't need to deal with TS-specifics later on in the compiler.

@svelte-docs-bot
Copy link

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dummdidumm dummdidumm merged commit 21dadfc into sveltejs:main Feb 12, 2025
8 checks passed
@github-actions github-actions bot mentioned this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract methods don't correctly compile in .svelte files
2 participants