Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow for duplicate var declarations #15382

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

paoloricciuti
Copy link
Member

Closes #15375

There was a comment above the line as you can see...while i agree with the comment i think we should try to stick with JS when possible. I tried to also include functions in this but there's an upstream bug in acorn that flag double function declarations as a js parse error.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@paoloricciuti paoloricciuti marked this pull request as ready for review February 24, 2025 20:54
Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: 025e511

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15382

@trueadm
Copy link
Contributor

trueadm commented Feb 24, 2025

Agreed, we should be sticking to JS semantics where possible so we teach people the caveats of the language too.

@paoloricciuti paoloricciuti merged commit c2ec0d9 into main Feb 24, 2025
10 checks passed
@paoloricciuti paoloricciuti deleted the duplicate-var-declarations branch February 24, 2025 22:38
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler throws declaration_duplicate for doubled var declarations
2 participants