Revert "By kuntal : "chore: remove System.out and printStackTrace to align with Sonar rules S106 and S1148""

kuntal1461 · kuntal1461 · commit b65ecbf80360 · 2025-10-08T00:09:38.000+05:30
This reverts commit 61467a9.
diff --git a/modules/swagger-core/src/main/java/io/swagger/v3/core/util/Json.java b/modules/swagger-core/src/main/java/io/swagger/v3/core/util/Json.java
@@ -3,13 +3,17 @@
 import com.fasterxml.jackson.core.util.DefaultPrettyPrinter;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.ObjectWriter;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class Json {
 
     private static final class ObjectMapperHolder {
         private static final ObjectMapper MAPPER = ObjectMapperFactory.createJson();
     }
 
+    static Logger LOGGER = LoggerFactory.getLogger(Json.class);
+
     public static ObjectMapper mapper() {
         return ObjectMapperHolder.MAPPER;
     }
@@ -22,16 +26,16 @@ public static String pretty(Object o) {
         try {
             return pretty().writeValueAsString(o);
         } catch (Exception e) {
-            e.printStackTrace();
+            LOGGER.error("Error serializing object to JSON", e);
             return null;
         }
     }
 
     public static void prettyPrint(Object o) {
         try {
-            System.out.println(pretty().writeValueAsString(o).replace("\r", ""));
+            LOGGER.debug(pretty().writeValueAsString(o).replace("\r", ""));
         } catch (Exception e) {
-            e.printStackTrace();
+            LOGGER.error("Error pretty-printing JSON", e);
         }
     }
 }
diff --git a/modules/swagger-core/src/main/java/io/swagger/v3/core/util/Json31.java b/modules/swagger-core/src/main/java/io/swagger/v3/core/util/Json31.java
@@ -39,16 +39,16 @@ public static String pretty(Object o) {
         try {
             return pretty().writeValueAsString(o);
         } catch (Exception e) {
-            e.printStackTrace();
+            LOGGER.error("Error serializing object to JSON (3.1)", e);
             return null;
         }
     }
 
     public static void prettyPrint(Object o) {
         try {
-            System.out.println(pretty().writeValueAsString(o).replace("\r", ""));
+            LOGGER.debug(pretty().writeValueAsString(o).replace("\r", ""));
         } catch (Exception e) {
-            e.printStackTrace();
+            LOGGER.error("Error pretty-printing JSON (3.1)", e);
         }
     }
 
diff --git a/modules/swagger-core/src/main/java/io/swagger/v3/core/util/Yaml.java b/modules/swagger-core/src/main/java/io/swagger/v3/core/util/Yaml.java
@@ -3,13 +3,17 @@
 import com.fasterxml.jackson.core.util.DefaultPrettyPrinter;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.ObjectWriter;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class Yaml {
 
     private static final class ObjectMapperHolder {
         private static final ObjectMapper MAPPER = ObjectMapperFactory.createYaml();
     }
 
+    static Logger LOGGER = LoggerFactory.getLogger(Yaml.class);
+
     public static ObjectMapper mapper() {
         return ObjectMapperHolder.MAPPER;
     }
@@ -22,16 +26,16 @@ public static String pretty(Object o) {
         try {
             return pretty().writeValueAsString(o);
         } catch (Exception e) {
-            e.printStackTrace();
+            LOGGER.error("Error serializing object to YAML", e);
             return null;
         }
     }
 
     public static void prettyPrint(Object o) {
         try {
-            System.out.println(pretty().writeValueAsString(o));
+            LOGGER.debug(pretty().writeValueAsString(o));
         } catch (Exception e) {
-            e.printStackTrace();
+            LOGGER.error("Error pretty-printing YAML", e);
         }
     }
 }
diff --git a/modules/swagger-core/src/main/java/io/swagger/v3/core/util/Yaml31.java b/modules/swagger-core/src/main/java/io/swagger/v3/core/util/Yaml31.java
@@ -31,16 +31,16 @@ public static String pretty(Object o) {
         try {
             return pretty().writeValueAsString(o);
         } catch (Exception e) {
-            e.printStackTrace();
+            LOGGER.error("Error serializing object to YAML (3.1)", e);
             return null;
         }
     }
 
     public static void prettyPrint(Object o) {
         try {
-            System.out.println(pretty().writeValueAsString(o));
+            LOGGER.debug(pretty().writeValueAsString(o));
         } catch (Exception e) {
-            e.printStackTrace();
+            LOGGER.error("Error pretty-printing YAML (3.1)", e);
         }
     }
 
diff --git a/modules/swagger-jaxrs2/src/main/java/io/swagger/v3/jaxrs2/integration/OpenApiServlet.java b/modules/swagger-jaxrs2/src/main/java/io/swagger/v3/jaxrs2/integration/OpenApiServlet.java
@@ -41,7 +41,7 @@ public void init(ServletConfig config) throws ServletException {
                     .ctxId(ctxId)
                     .buildContext(true);
         } catch (OpenApiConfigurationException e) {
-            e.printStackTrace();
+            LOGGER.error("Failed to initialize OpenAPI servlet context", e);
         }
     }
 
diff --git a/modules/swagger-maven-plugin/src/main/java/io/swagger/v3/plugin/maven/IncludeProjectDependenciesComponentConfigurator.java b/modules/swagger-maven-plugin/src/main/java/io/swagger/v3/plugin/maven/IncludeProjectDependenciesComponentConfigurator.java
@@ -39,8 +39,9 @@ public void configureComponent(Object component, PlexusConfiguration configurati
     private void addProjectDependenciesToClassRealm(ExpressionEvaluator expressionEvaluator, ClassRealm containerRealm) throws ComponentConfigurationException {
         List<String> compileClasspathElements;
         try {
-            //noinspection unchecked
-            compileClasspathElements = (List<String>) expressionEvaluator.evaluate("${project.compileClasspathElements}");
+            @SuppressWarnings("unchecked")
+            List<String> evaluated = (List<String>) expressionEvaluator.evaluate("${project.compileClasspathElements}");
+            compileClasspathElements = evaluated;
         } catch (ExpressionEvaluationException e) {
             throw new ComponentConfigurationException("There was a problem evaluating: ${project.compileClasspathElements}", e);
         }
@@ -68,4 +69,4 @@ private URL[] buildURLs(List<String> runtimeClasspathElements) throws ComponentC
         return urls.toArray(new URL[urls.size()]);
     }
 
-}
+}
diff --git a/modules/swagger-project-jakarta/modules/swagger-maven-plugin-jakarta/src/main/java/io/swagger/v3/plugin/maven/jakarta/JakartaTransformer.java b/modules/swagger-project-jakarta/modules/swagger-maven-plugin-jakarta/src/main/java/io/swagger/v3/plugin/maven/jakarta/JakartaTransformer.java
@@ -1,5 +1,8 @@
 package io.swagger.v3.plugin.maven.jakarta;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import java.io.BufferedInputStream;
 import java.io.BufferedReader;
 import java.io.BufferedWriter;
@@ -42,6 +45,8 @@
  */
 public class JakartaTransformer {
 
+    private static final Logger LOGGER = LoggerFactory.getLogger(JakartaTransformer.class);
+
 
     /*
      *  Substitution tokens + regex
@@ -212,7 +217,7 @@ public FileVisitResult visitFile(Path file,
                     Files.copy(file, pathInZipfile, options);
 
                 } catch (IOException e) {
-                    e.printStackTrace();
+                    LOGGER.error("Error copying file '{}' into ZIP filesystem", file, e);
                 }
 
                 return FileVisitResult.CONTINUE;

Original file line number	Diff line number	Diff line change
`@@ -3,13 +3,17 @@`
`3`	`3`	`import com.fasterxml.jackson.core.util.DefaultPrettyPrinter;`
`4`	`4`	`import com.fasterxml.jackson.databind.ObjectMapper;`
`5`	`5`	`import com.fasterxml.jackson.databind.ObjectWriter;`
	`6`	`+import org.slf4j.Logger;`
	`7`	`+import org.slf4j.LoggerFactory;`
`6`	`8`
`7`	`9`	`public class Json {`
`8`	`10`
`9`	`11`	`private static final class ObjectMapperHolder {`
`10`	`12`	`private static final ObjectMapper MAPPER = ObjectMapperFactory.createJson();`
`11`	`13`	`}`
`12`	`14`
	`15`	`+ static Logger LOGGER = LoggerFactory.getLogger(Json.class);`
	`16`	`+`
`13`	`17`	`public static ObjectMapper mapper() {`
`14`	`18`	`return ObjectMapperHolder.MAPPER;`
`15`	`19`	`}`
`@@ -22,16 +26,16 @@ public static String pretty(Object o) {`
`22`	`26`	`try {`
`23`	`27`	`return pretty().writeValueAsString(o);`
`24`	`28`	`} catch (Exception e) {`
`25`		`- e.printStackTrace();`
	`29`	`+ LOGGER.error("Error serializing object to JSON", e);`
`26`	`30`	`return null;`
`27`	`31`	`}`
`28`	`32`	`}`
`29`	`33`
`30`	`34`	`public static void prettyPrint(Object o) {`
`31`	`35`	`try {`
`32`		`- System.out.println(pretty().writeValueAsString(o).replace("\r", ""));`
	`36`	`+ LOGGER.debug(pretty().writeValueAsString(o).replace("\r", ""));`
`33`	`37`	`} catch (Exception e) {`
`34`		`- e.printStackTrace();`
	`38`	`+ LOGGER.error("Error pretty-printing JSON", e);`
`35`	`39`	`}`
`36`	`40`	`}`
`37`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,16 +39,16 @@ public static String pretty(Object o) {`
`39`	`39`	`try {`
`40`	`40`	`return pretty().writeValueAsString(o);`
`41`	`41`	`} catch (Exception e) {`
`42`		`- e.printStackTrace();`
	`42`	`+ LOGGER.error("Error serializing object to JSON (3.1)", e);`
`43`	`43`	`return null;`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`public static void prettyPrint(Object o) {`
`48`	`48`	`try {`
`49`		`- System.out.println(pretty().writeValueAsString(o).replace("\r", ""));`
	`49`	`+ LOGGER.debug(pretty().writeValueAsString(o).replace("\r", ""));`
`50`	`50`	`} catch (Exception e) {`
`51`		`- e.printStackTrace();`
	`51`	`+ LOGGER.error("Error pretty-printing JSON (3.1)", e);`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`
Original file line number	Diff line number	Diff line change
`@@ -31,16 +31,16 @@ public static String pretty(Object o) {`
`31`	`31`	`try {`
`32`	`32`	`return pretty().writeValueAsString(o);`
`33`	`33`	`} catch (Exception e) {`
`34`		`- e.printStackTrace();`
	`34`	`+ LOGGER.error("Error serializing object to YAML (3.1)", e);`
`35`	`35`	`return null;`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`public static void prettyPrint(Object o) {`
`40`	`40`	`try {`
`41`		`- System.out.println(pretty().writeValueAsString(o));`
	`41`	`+ LOGGER.debug(pretty().writeValueAsString(o));`
`42`	`42`	`} catch (Exception e) {`
`43`		`- e.printStackTrace();`
	`43`	`+ LOGGER.error("Error pretty-printing YAML (3.1)", e);`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public void init(ServletConfig config) throws ServletException {`
`41`	`41`	`.ctxId(ctxId)`
`42`	`42`	`.buildContext(true);`
`43`	`43`	`} catch (OpenApiConfigurationException e) {`
`44`		`- e.printStackTrace();`
	`44`	`+ LOGGER.error("Failed to initialize OpenAPI servlet context", e);`
`45`	`45`	`}`
`46`	`46`	`}`
`47`	`47`