perf(es/minifier): Prevent double boxing

kdy1 · kdy1 · commit 7b2a6d3eaacd · 2025-02-21T04:54:05.000Z
diff --git a/crates/swc_ecma_minifier/src/program_data.rs b/crates/swc_ecma_minifier/src/program_data.rs
@@ -120,7 +120,7 @@ pub(crate) struct VarUsageInfo {
     /// PR. (because it's hard to review)
     infects_to: Vec<Access>,
     /// Only **string** properties.
-    pub(crate) accessed_props: Box<FxHashMap<Atom, u32>>,
+    pub(crate) accessed_props: FxHashMap<Atom, u32>,
 
     pub(crate) used_recursively: bool,
 }
@@ -294,7 +294,7 @@ impl Storage for ProgramData {
 
                     e.get_mut().assigned_fn_local &= var_info.assigned_fn_local;
 
-                    for (k, v) in *var_info.accessed_props {
+                    for (k, v) in var_info.accessed_props {
                         *e.get_mut().accessed_props.entry(k).or_default() += v;
                     }
 

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ pub(crate) struct VarUsageInfo {`
`120`	`120`	`/// PR. (because it's hard to review)`
`121`	`121`	`infects_to: Vec<Access>,`
`122`	`122`	`/// Only string properties.`
`123`		`- pub(crate) accessed_props: Box<FxHashMap<Atom, u32>>,`
	`123`	`+ pub(crate) accessed_props: FxHashMap<Atom, u32>,`
`124`	`124`
`125`	`125`	`pub(crate) used_recursively: bool,`
`126`	`126`	`}`
`@@ -294,7 +294,7 @@ impl Storage for ProgramData {`
`294`	`294`
`295`	`295`	`e.get_mut().assigned_fn_local &= var_info.assigned_fn_local;`
`296`	`296`
`297`		`- for (k, v) in *var_info.accessed_props {`
	`297`	`+ for (k, v) in var_info.accessed_props {`
`298`	`298`	`*e.get_mut().accessed_props.entry(k).or_default() += v;`
`299`	`299`	`}`
`300`	`300`