Skip to content

ci: use Node.js 24 for wasm publishing#12038

Merged
kdy1 merged 1 commit into
mainfrom
kdy1/fix-wasm-publish-node-24
Jul 19, 2026
Merged

ci: use Node.js 24 for wasm publishing#12038
kdy1 merged 1 commit into
mainfrom
kdy1/fix-wasm-publish-node-24

Conversation

@kdy1

@kdy1 kdy1 commented Jul 19, 2026

Copy link
Copy Markdown
Member

Description:

The WASM publishing matrix was still using Node.js 20 while installing npm@latest. In the failed publish run, that resolved to npm 12.0.1, which requires Node.js ^22.22.2 || ^24.15.0 || >=26.0.0, so all six WASM packages failed in the Update npm step with EBADENGINE.

Use Node.js 24 for the WASM publish jobs, matching the repository's default Node.js version and the regular npm publish job that successfully installed the same npm release. This only changes the publishing environment and does not change the published packages' runtime compatibility.

Validation:

  • actionlint 1.7.12 -color -shellcheck=
  • git diff --check
  • cargo fmt --all
  • cargo clippy --all --all-targets -- -D warnings

Related issue (if exists):

@changeset-bot

changeset-bot Bot commented Jul 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cbd55d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1
kdy1 marked this pull request as ready for review July 19, 2026 07:19
@kdy1
kdy1 requested a review from a team as a code owner July 19, 2026 07:19
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@kdy1
kdy1 enabled auto-merge (squash) July 19, 2026 07:20
@kdy1
kdy1 disabled auto-merge July 19, 2026 07:24
@kdy1 kdy1 changed the title fix(ci): use Node.js 24 for wasm publishing ci: use Node.js 24 for wasm publishing Jul 19, 2026
@kdy1
kdy1 merged commit 516bf3c into main Jul 19, 2026
195 checks passed
@kdy1
kdy1 deleted the kdy1/fix-wasm-publish-node-24 branch July 19, 2026 07:24
@github-actions github-actions Bot added this to the Planned milestone Jul 19, 2026
@codspeed-hq

codspeed-hq Bot commented Jul 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 189 untouched benchmarks
⏩ 61 skipped benchmarks1


Comparing kdy1/fix-wasm-publish-node-24 (cbd55d9) with main (d1a1e23)2

Open in CodSpeed

Footnotes

  1. 61 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (1b17f34) during the generation of this report, so d1a1e23 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-actions github-actions Bot modified the milestones: Planned, v1.15.46 Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant