Skip to content

Setting of Swift_MODULE_DIRECTORY (and probably other directories) inappropriate. #2680

Open
@dabrahams

Description

@dabrahams

https://github.com/apple/swift-syntax/blob/e072677b26ad9a46b15f59fa2b5d7edf4f808e4f/cmake/modules/AddSwiftHostLibrary.cmake#L69-L71

See this warning, which says that it's incompatible with multi-config generators. It also overrides a decision that should be the prerogative of the top level CMake project and if nothing else should be conditionalized on PROJECT_IS_TOP_LEVEL. But really it shouldn't be set at all. All of these settings artificially group files in a way that can cause builds to succeed even if dependencies have not been properly specified, or fail if properly specified, and if nothing else are likely to break all multi-config generators (which includes Xcode) for the forseeable future.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions