Skip to content

Sovler-based cursor info is reporting refactorings that aren’t applicable with AST-based refactoring implementation #64512

Open
@ahoppen

Description

@ahoppen

The solver-based cursor info reports rename refactorings based on whether it resolved the current item. But since the refactoring itself uses the AST-based implementation the refactoring might not actually be applicable. We probably need to still run the AST-based implementation for cursor info to tell if rename is actually available.

The proper solution here would probably be to create two requests: One that just returns the cursor info and another one that returns the available refactorings. The latter could then use the AST-based implementation while the former is purely solver-based.

Metadata

Metadata

Assignees

No one assigned

    Labels

    SourceKitArea → source tooling: SourceKitbugA deviation from expected or documented behavior. Also: expected but undesirable behavior.cursor infoArea → source tooling: cursor infofound by stress testerFlag: An issue found by the SourceKit stress testersource toolingArea: IDE support, SourceKit, and other source tooling

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions