[6.2][cxx-interop] Types exposed from ObjC modules should be behind a macro #83065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
added
c++ interop
… macro Explanation: We the generated reverse interop headers to be valid C++, so every declaration coming from an Obj-C module should be behind an ifdef. Unfortunately, we do not always have this information but we do know that our frameworks contain Obj-C code. So this PR makes sure every entity coming from our frameworks are behind ifdef. Issues: rdar://152836730 Original PRs: swiftlang#83002 Risk: Low, the change is narrow and straightforward. Testing: Added a compiler test. Reviewers: @egorzhdan
Xazax-hun
force-pushed
the
guard-more-objc-on-6.2
branch
from
a8130d8 to
ab12392
Compare
We sometimes don't have the information in the modulemaps whether a module requires ObjC or not. This info is useful for reverse interop. This PR introduces a frontend flag to have a comma separated list of modules that we should import as if they had "requires ObjC" in their modulemaps.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: We the generated reverse interop headers to be valid C++, so every declaration coming from an Obj-C module should be behind an ifdef. Unfortunately, we do not always have this information. So this PR introduces an experimental flag to determine which modules should be considered ObjC.
Issues: rdar://152836730
Original PRs: #83002, #83130
Risk: Low, the change is noop for users not using the flag and not having requires objc in their modulemap.
Testing: Added a compiler test.
Reviewers: @egorzhdan