Runtimes: reworking Distributed build to work on Windows #83157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary change required here is to remove the `LINKER_LANGUAGE` property on the target with policy CMP0157 set to `OLD`. Take the opportunity to re-order the flag handling to match the other runtime library CMakeLists making it easier to diff them. `-library-level api` is implicitly handled by the `emit_swift_interface` call, so remove that. The other runtimes use a centralised `ExperimentalFeatures` which would add in the unsafe support. While in the area, add in a dependency on `SwiftOverlay` to wire up the `builtin_float` module dependency as well.
compnerd
requested review from
etcwilde,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
etcwilde
reviewed
Jul 17, 2025
| LocalTestingDistributedActorSystem.swift) | ||
|
|
||
| target_compile_options(swiftDistributed PRIVATE | ||
| add_compile_options( |
There was a problem hiding this comment.
Why are we switching to add_compile_options here?
There was a problem hiding this comment.
To keep in sync with the other modules that we are building. It makes diffing the CMakeLists.txt easier.
ktoso
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary change required here is to remove the
LINKER_LANGUAGEproperty on the target with policy CMP0157 set toOLD. Take the opportunity to re-order the flag handling to match the other runtime library CMakeLists making it easier to diff them.-library-level apiis implicitly handled by theemit_swift_interfacecall, so remove that. The other runtimes use a centralisedExperimentalFeatureswhich would add in the unsafe support. While in the area, add in a dependency onSwiftOverlayto wire up thebuiltin_floatmodule dependency as well.