Make work so we can run locally without publishing

Author: award999

.github/workflows/nightly.yml

@@ -18,9 +18,6 @@ jobs:
         uses: actions/checkout@v4
       - name: Build Extension
         run: |
-          export NODE_VERSION=v18.19.0
-          export NODE_PATH=/usr/local/nvm/versions/node/v18.19.0/bin
-          export NVM_DIR=/usr/local/nvm
           . .github/workflows/scripts/setup-linux.sh
           [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
           npm ci
@@ -34,26 +31,23 @@ jobs:
       - name: Archive production artifacts
         id: archive
         uses: actions/upload-artifact@v4
-        if: always()
+        if: ${{ env.ACT != 'true' }}
         with:
           if-no-files-found: error
           name: vscode-swift-extension
           path: |
             *.vsix
+        
   tests_release:
     name: Test Release
     needs: package
-    uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@main
+    uses: award999/github-workflows/.github/workflows/swift_package_test.yml@token
     with:
+      needs_token: true
       # Linux
       linux_env_vars: |
-        NODE_VERSION=v18.19.0
-        NODE_PATH=/usr/local/nvm/versions/node/v18.19.0/bin
-        NVM_DIR=/usr/local/nvm
         CI=1
         VSCODE_SWIFT_VSIX_ID=${{needs.package.outputs.artifact-id}}
-        VSCODE_SWIFT_VSIX=vscode-swift.vsix
-        GITHUB_TOKEN=${{github.token}}
         GITHUB_REPOSITORY=${{github.repository}}
       linux_pre_build_command: . .github/workflows/scripts/setup-linux.sh
       linux_build_command: ./scripts/test.sh
@@ -63,7 +57,6 @@ jobs:
         VSCODE_TEST=1
         VSCODE_SWIFT_VSIX_ID=${{needs.package.outputs.artifact-id}}
         VSCODE_SWIFT_VSIX=vscode-swift.vsix
-        GITHUB_TOKEN=${{github.token}}
         GITHUB_REPOSITORY=${{github.repository}}
       windows_pre_build_command: .github\workflows\scripts\windows\setup.ps1
       windows_build_command: scripts\test_windows.ps1
@@ -72,20 +65,16 @@ jobs:
   tests_insiders:
     name: Test Insiders
     needs: package
-    uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@main
+    uses: award999/github-workflows/.github/workflows/swift_package_test.yml@token
     with:
+      needs_token: true
       # Linux
       linux_exclude_swift_versions: '[{"swift_version": "5.8"}, {"swift_version": "5.9"}, {"swift_version": "5.10"}, {"swift_version": "nightly-6.1"}, {"swift_version": "nightly-main"}]'
       linux_env_vars: |
-        NODE_VERSION=v18.19.0
-        NODE_PATH=/usr/local/nvm/versions/node/v18.19.0/bin
-        NVM_DIR=/usr/local/nvm
         CI=1
         VSCODE_TEST=1
         VSCODE_VERSION=insiders
         VSCODE_SWIFT_VSIX_ID=${{needs.package.outputs.artifact-id}}
-        VSCODE_SWIFT_VSIX=vscode-swift.vsix
-        GITHUB_TOKEN=${{github.token}}
         GITHUB_REPOSITORY=${{github.repository}}
       linux_pre_build_command: . .github/workflows/scripts/setup-linux.sh
       linux_build_command: ./scripts/test.sh
@@ -97,7 +86,6 @@ jobs:
         VSCODE_VERSION=insiders
         VSCODE_SWIFT_VSIX_ID=${{needs.package.outputs.artifact-id}}
         VSCODE_SWIFT_VSIX=vscode-swift.vsix
-        GITHUB_TOKEN=${{github.token}}
         GITHUB_REPOSITORY=${{github.repository}}
       windows_pre_build_command: .github\workflows\scripts\windows\setup.ps1
       windows_build_command: scripts\test_windows.ps1

.github/workflows/scripts/setup-linux.sh

@@ -19,13 +19,15 @@ export NVM_DIR=/usr/local/nvm
 
 apt-get update && apt-get install -y rsync curl gpg libasound2 libgbm1 libgtk-3-0 libnss3 xvfb build-essential
 
-if [ ! -z "$VSCODE_SWIFT_VSIX_URL" ]; then
-    export VSCODE_SWIFT_VSIX="$PWD/vscode-swift.vsix"
-    echo "Downloading $VSCODE_SWIFT_VSIX_URL to $VSCODE_SWIFT_VSIX"
-    curl -o "$VSCODE_SWIFT_VSIX" "$VSCODE_SWIFT_VSIX_URL" 
-fi
-
 mkdir -p $NVM_DIR
 curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash
-/bin/bash -c "source $NVM_DIR/nvm.sh && nvm install $NODE_VERSION"
-echo "$NODE_PATH" >> "$GITHUB_PATH"
+. $NVM_DIR/nvm.sh && nvm install $NODE_VERSION
+echo "$NODE_PATH" >> "$GITHUB_PATH"
+
+env | sort
+
+if [ ! -z "$VSCODE_SWIFT_VSIX_ID" ]; then
+    npm ci --ignore-scripts
+    npx tsx scripts/download_vsix.ts
+    export VSCODE_SWIFT_VSIX="vscode-swift.vsix"
+fi

.github/workflows/scripts/windows/setup.ps1

@@ -3,4 +3,10 @@
 
 # Download the VSIX archived upstream
 npm ci -ignore-script node-pty
-npx tsx scripts/download_vsix.ts
+$Process = Start-Process npx "tsx scripts/download_vsix.ts" -Wait -PassThru -NoNewWindow
+if ($Process.ExitCode -eq 0) {
+    Write-Host 'SUCCESS'
+} else {
+    Write-Host  ('FAILED ({0})' -f $Process.ExitCode)
+    exit 1
+}

.vscode-test.js

@@ -14,7 +14,7 @@
 
 const { defineConfig } = require("@vscode/test-cli");
 const path = require("path");
-const { version } = require("./package.json");
+const { version, publisher, name } = require("./package.json");
 
 const isCIBuild = process.env["CI"] === "1";
 const isFastTestRun = process.env["FAST_TEST_RUN"] === "1";
@@ -66,7 +66,7 @@ module.exports = defineConfig({
             workspaceFolder: "./assets/test",
             launchArgs,
             extensionDevelopmentPath: vsixPath
-                ? [`${__dirname}/.vscode-test/extensions/swiftlang.vscode-swift-${version}`]
+                ? [`${__dirname}/.vscode-test/extensions/${publisher}.${name}-${version}`]
                 : undefined,
             mocha: {
                 ui: "tdd",
@@ -103,6 +103,7 @@ module.exports = defineConfig({
                     },
                 },
             },
+            skipExtensionDependencies: true,
             reuseMachineInstall: !isCIBuild,
         },
         // you can specify additional test configurations, too

scripts/download_vsix.ts

@@ -22,19 +22,18 @@ import { Octokit } from "octokit";
 const artifact_id = process.env["VSCODE_SWIFT_VSIX_ID"];
 if (!artifact_id) {
     console.error("No VSCODE_SWIFT_VSIX_ID provided");
-    process.exit(1);
+    process.exit(0);
 }
 const token = process.env["GITHUB_TOKEN"];
 if (!token) {
     console.error("No GITHUB_TOKEN provided");
     process.exit(1);
 }
 const repository = process.env["GITHUB_REPOSITORY"] || "swiftlang/vscode-swift";
+const owner = repository.split("/")[0];
+const repo = repository.split("/")[1];
 
 (async function () {
-    const owner = repository.split("/")[0];
-    const repo = repository.split("/")[1];
-
     const octokit = new Octokit({
         auth: token,
     });
@@ -56,6 +55,9 @@ const repository = process.env["GITHUB_REPOSITORY"] || "swiftlang/vscode-swift";
     );
     await pipeline(data, createWriteStream("artifacts.zip", data));
     const files = await decompress("artifacts.zip", process.cwd());
-    await rename(files[0].path, "vscode-swift.vsix");
+    console.log(`Downloaded artifact(s): ${files.map(f => f.path).join(", ")}`);
+    const newName = process.env["VSCODE_SWIFT_VSIX"] || "vscode-swift.vsix";
+    await rename(files[0].path, newName);
+    console.log(`Renamed artifact: ${files[0].path} => ${newName}`);
     await unlink("artifacts.zip");
 })();

scripts/test_windows.ps1

@@ -18,6 +18,7 @@ npm ci -ignore-script node-pty
 npm run lint
 npm run format
 npm run package
+npm test -- --label installExtension
 $Process = Start-Process npm "run integration-test" -Wait -PassThru -NoNewWindow
 if ($Process.ExitCode -eq 0) {
     Write-Host 'SUCCESS'