-
Notifications
You must be signed in to change notification settings - Fork 72
Ensure GH CodeSpaces work #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Unfortunately, the extension is a bit too eager, and wants to update the VSCode settings on every start of the codespace.
If you accept the following setting will be set This path does not work for me, LLDB cannot be started. The correct path is. |
Interesting the lldb library the extension wants to use is the library that the swift version of lldb reports it is using. How are you setting up to run in Codespaces? I haven't looked into the Codespace stuff at all yet. |
I use a slightly modified version of devcontainer |
What version of the extension are you running? There was a fix in 0.1.1 related to remote containers and lldb. |
Also that devcontainer includes a different swift extension. Have you tried a slightly simpler devcontainer.json
|
This is my devcontainer.json
|
I found the solution, the dockerfile from MS installs LLDB. Without it the extension does the right thing. |
Oh yeah I remember seeing that. I think at that point I decided I'd use my simple devcontainer from above. The MS version does all sorts of stuff that doesn't seem that necessary. |
I made a pull request at microsoft, so that no one else stumbles across this. |
Given vscode.dev and CodeSpaces are different things I think we should break this into two issues. I believe once microsoft/vscode-dev-containers#1238 is resolved we can do the same for CodeSpaces. vscode.dev is a different thing and requires us supporting web extensions which severely limits what we can do. |
Ok I agree. I'll change this to Codespaces and create a separate issue for vscode.dev |
As an aside - does anyone have access to Codespaces? I didn't get on to the individual beta and none of the orgs I control has been given access to it yet @damuellen do the new remote dev docs now work for a Codespace as well as regular remote dev running locally? |
In Codespace it works as it should, I have not tested another setup. |
We should ensure that the extension works when running in GitHub CodeSpaces
and on vscode.dev. I'm pretty sure they should be fine as remote containers now work but we might need to provide some additional configuration or ensure a Dockerfile is set up correctly. Any required setup should go in the docsThe text was updated successfully, but these errors were encountered: