fix(episode-discharge): changed response when no discharge is found to 200

Author: dkoutsonikolis

tmh_registry/registry/api/viewsets.py

@@ -203,11 +203,11 @@ def discharge(self, request, pk=None):
             raise NotFound(f"Episode {pk=} not found.")
 
         try:
-            serializer = DischargeReadSerializer(episode.discharge)
+            data = DischargeReadSerializer(episode.discharge).data
         except AttributeError:
-            raise NotFound(f"Discharge for Episode {pk=} not found.")
+            data = {}
 
-        return Response(serializer.data)
+        return Response(data)
 
     @swagger_auto_schema(
         method="get",

tmh_registry/registry/tests/api/viewsets/episodes/test_get_discharge.py

@@ -32,7 +32,8 @@ def test_when_episode_exists_but_discharge_does_not(self):
             f"/api/v1/episodes/{self.episode.id}/discharge/"
         )
 
-        self.assertEqual(HTTP_404_NOT_FOUND, response.status_code)
+        self.assertEqual(HTTP_200_OK, response.status_code)
+        self.assertEqual({}, response.data)
 
     def test_successful(self):
         discharge = DischargeFactory(episode=self.episode)