[region-isolation] Rename RequireInOutSendingAtFunctionExit -> InOutSendingAtFunctionExit.

I am going to be doing more types of checks for such inout sending types, so it
makes sense to rename it to have a more general name.

Author: gottesmm

include/swift/SILOptimizer/Utils/PartitionUtils.h

@@ -460,7 +460,7 @@ enum class PartitionOpKind : uint8_t {
   /// parameter is reinitialized with a disconnected value.
   ///
   /// Takes one parameter, the inout parameter that we need to check.
-  RequireInOutSendingAtFunctionExit,
+  InOutSendingAtFunctionExit,
 };
 
 /// PartitionOp represents a primitive operation that can be performed on
@@ -568,9 +568,9 @@ class PartitionOp {
     return PartitionOp(PartitionOpKind::UnknownPatternError, elt, sourceInst);
   }
 
-  static PartitionOp
-  RequireInOutSendingAtFunctionExit(Element elt, SILInstruction *sourceInst) {
-    return PartitionOp(PartitionOpKind::RequireInOutSendingAtFunctionExit, elt,
+  static PartitionOp InOutSendingAtFunctionExit(Element elt,
+                                                SILInstruction *sourceInst) {
+    return PartitionOp(PartitionOpKind::InOutSendingAtFunctionExit, elt,
                        sourceInst);
   }
 
@@ -1399,7 +1399,7 @@ struct PartitionOpEvaluator {
         }
       }
       return;
-    case PartitionOpKind::RequireInOutSendingAtFunctionExit: {
+    case PartitionOpKind::InOutSendingAtFunctionExit: {
       assert(op.getOpArgs().size() == 1 &&
              "Require PartitionOp should be passed 1 argument");
       assert(p.isTrackingElement(op.getOpArgs()[0]) &&

lib/SILOptimizer/Analysis/RegionAnalysis.cpp

@@ -1240,12 +1240,12 @@ struct PartitionOpBuilder {
         PartitionOp::Require(lookupValueID(value), currentInst));
   }
 
-  void addRequireInOutSendingAtFunctionExit(SILValue value) {
+  void addInOutSendingAtFunctionExit(SILValue value) {
     assert(valueHasID(value, /*dumpIfHasNoID=*/true) &&
            "required value should already have been encountered");
     currentInstPartitionOps.emplace_back(
-        PartitionOp::RequireInOutSendingAtFunctionExit(lookupValueID(value),
-                                                       currentInst));
+        PartitionOp::InOutSendingAtFunctionExit(lookupValueID(value),
+                                                currentInst));
   }
 
   void addUnknownPatternError(SILValue value) {
@@ -2402,15 +2402,15 @@ class PartitionOpTranslator {
 
   /// Adds requires for all sending inout parameters to make sure that they are
   /// properly updated before the end of the function.
-  void addRequiresForInOutParameters(TermInst *inst) {
+  void addEndOfFunctionChecksForInOutSendingParameters(TermInst *inst) {
     assert(inst->isFunctionExiting() && "Must be function exiting term inst?!");
     for (auto *arg : inst->getFunction()->getArguments()) {
       auto *fArg = cast<SILFunctionArgument>(arg);
       if (fArg->getArgumentConvention().isInoutConvention() &&
           fArg->getKnownParameterInfo().hasOption(SILParameterInfo::Sending)) {
         if (auto ns = tryToTrackValue(arg)) {
           auto rep = ns->getRepresentative().getValue();
-          builder.addRequireInOutSendingAtFunctionExit(rep);
+          builder.addInOutSendingAtFunctionExit(rep);
         }
       }
     }
@@ -2838,7 +2838,7 @@ CONSTANT_TRANSLATION(DynamicMethodBranchInst, TerminatorPhi)
 #define FUNCTION_EXITING_TERMINATOR_CONSTANT(INST, Kind)                       \
   TranslationSemantics PartitionOpTranslator::visit##INST(INST *inst) {        \
     assert(inst->isFunctionExiting() && "Must be function exiting?!");         \
-    addRequiresForInOutParameters(inst);                                       \
+    addEndOfFunctionChecksForInOutSendingParameters(inst);                     \
     return TranslationSemantics::Kind;                                         \
   }
 
@@ -3090,7 +3090,7 @@ PartitionOpTranslator::visitLoadBorrowInst(LoadBorrowInst *lbi) {
 }
 
 TranslationSemantics PartitionOpTranslator::visitReturnInst(ReturnInst *ri) {
-  addRequiresForInOutParameters(ri);
+  addEndOfFunctionChecksForInOutSendingParameters(ri);
   if (ri->getFunction()->getLoweredFunctionType()->hasSendingResult()) {
     return TranslationSemantics::TransferringNoResult;
   }

lib/SILOptimizer/Utils/PartitionUtils.cpp

@@ -78,9 +78,9 @@ void PartitionOp::print(llvm::raw_ostream &os, bool extraSpace) const {
     os << "unknown pattern error ";
     os << "%%" << opArgs[0];
     break;
-  case PartitionOpKind::RequireInOutSendingAtFunctionExit:
+  case PartitionOpKind::InOutSendingAtFunctionExit:
     constexpr static char extraSpaceLiteral[10] = "     ";
-    os << "require_inout_sending_at_function_exit ";
+    os << "inout_sending_at_function_exit ";
     if (extraSpace)
       os << extraSpaceLiteral;
     os << "%%" << opArgs[0];