From e17b7989edcae760ea72e381166ef87bd6ae88f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Polykanine?= Date: Fri, 7 Feb 2025 20:12:04 +0100 Subject: [PATCH 1/3] Make:entity: Add question about unsigned integer --- src/Maker/MakeEntity.php | 2 ++ tests/Maker/MakeEntityTest.php | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/src/Maker/MakeEntity.php b/src/Maker/MakeEntity.php index e0498f36b..6652658c5 100644 --- a/src/Maker/MakeEntity.php +++ b/src/Maker/MakeEntity.php @@ -435,6 +435,8 @@ private function askForNextField(ConsoleStyle $io, array $fields, string $entity // set type according to user decision $classProperty->type = $io->confirm('Can this field store multiple enum values', false) ? 'simple_array' : 'string'; + } else if ('integer' === $type) { + $classProperty->options['unsigned'] = $io->confirm('Is this an unsigned integer', false); } if ($io->confirm('Can this field be null in the database (nullable)', false)) { diff --git a/tests/Maker/MakeEntityTest.php b/tests/Maker/MakeEntityTest.php index cf72700ad..d2e5c8298 100644 --- a/tests/Maker/MakeEntityTest.php +++ b/tests/Maker/MakeEntityTest.php @@ -194,6 +194,12 @@ public function getTestDetails(): \Generator '255', // length // nullable 'y', + 'rating', + 'integer', + // Unsigned + 'y', + // Not nullable + 'n', 'createdAt', // use default datetime '', From b8e94f2d9704d9e0651af95d64b097bd50f7efb4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Polykanine?= Date: Fri, 7 Feb 2025 20:20:54 +0100 Subject: [PATCH 2/3] Fix CS --- src/Maker/MakeEntity.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Maker/MakeEntity.php b/src/Maker/MakeEntity.php index 6652658c5..8e22f38d9 100644 --- a/src/Maker/MakeEntity.php +++ b/src/Maker/MakeEntity.php @@ -435,7 +435,7 @@ private function askForNextField(ConsoleStyle $io, array $fields, string $entity // set type according to user decision $classProperty->type = $io->confirm('Can this field store multiple enum values', false) ? 'simple_array' : 'string'; - } else if ('integer' === $type) { + } elseif ('integer' === $type) { $classProperty->options['unsigned'] = $io->confirm('Is this an unsigned integer', false); } From 6330babd13143265f89b1979b8125d9c93d1cc03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Polykanine?= Date: Fri, 7 Feb 2025 20:32:10 +0100 Subject: [PATCH 3/3] Attempt to fix test --- tests/Maker/MakeEntityTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Maker/MakeEntityTest.php b/tests/Maker/MakeEntityTest.php index d2e5c8298..fe03d6a4a 100644 --- a/tests/Maker/MakeEntityTest.php +++ b/tests/Maker/MakeEntityTest.php @@ -198,8 +198,8 @@ public function getTestDetails(): \Generator 'integer', // Unsigned 'y', - // Not nullable - 'n', + // Nullable + 'y', 'createdAt', // use default datetime '',