bug #53529 [Ldap] Use {user_identifier} over deprecated {username} in factories (tcitworld)

This PR was merged into the 7.0 branch.

Discussion
----------

[Ldap] Use `{user_identifier}` over deprecated `{username}` in factories

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

In SF 7.0, the deprecated `{username}` placeholder was removed in favor of `{user_identifier}` (in #50866). However, the default values for the `filter` and `dn_string` parameters still contained `{username}` instead of the updated key.

This PR changes the value to the new updated key

Commits
-------

30baf8228e fix(ldap): replace {username} with {user_identifier} in LDAP factories

Author: fabpot

DependencyInjection/Security/Factory/FormLoginLdapFactory.php

@@ -32,7 +32,7 @@ public function addConfiguration(NodeDefinition $node): void
         $node
             ->children()
                 ->scalarNode('service')->defaultValue('ldap')->end()
-                ->scalarNode('dn_string')->defaultValue('{username}')->end()
+                ->scalarNode('dn_string')->defaultValue('{user_identifier}')->end()
                 ->scalarNode('query_string')->end()
                 ->scalarNode('search_dn')->defaultValue('')->end()
                 ->scalarNode('search_password')->defaultValue('')->end()

DependencyInjection/Security/Factory/HttpBasicLdapFactory.php

@@ -77,7 +77,7 @@ public function addConfiguration(NodeDefinition $node): void
         $node
             ->children()
                 ->scalarNode('service')->defaultValue('ldap')->end()
-                ->scalarNode('dn_string')->defaultValue('{username}')->end()
+                ->scalarNode('dn_string')->defaultValue('{user_identifier}')->end()
                 ->scalarNode('query_string')->end()
                 ->scalarNode('search_dn')->defaultValue('')->end()
                 ->scalarNode('search_password')->defaultValue('')->end()

DependencyInjection/Security/Factory/JsonLoginLdapFactory.php

@@ -29,7 +29,7 @@ public function addConfiguration(NodeDefinition $node): void
         $node
             ->children()
                 ->scalarNode('service')->defaultValue('ldap')->end()
-                ->scalarNode('dn_string')->defaultValue('{username}')->end()
+                ->scalarNode('dn_string')->defaultValue('{user_identifier}')->end()
                 ->scalarNode('query_string')->end()
                 ->scalarNode('search_dn')->defaultValue('')->end()
                 ->scalarNode('search_password')->defaultValue('')->end()

DependencyInjection/Security/UserProvider/LdapFactory.php

@@ -64,7 +64,7 @@ public function addConfiguration(NodeDefinition $node): void
                     ->prototype('scalar')->end()
                 ->end()
                 ->scalarNode('uid_key')->defaultValue('sAMAccountName')->end()
-                ->scalarNode('filter')->defaultValue('({uid_key}={username})')->end()
+                ->scalarNode('filter')->defaultValue('({uid_key}={user_identifier})')->end()
                 ->scalarNode('password_attribute')->defaultNull()->end()
             ->end()
         ;