Skip to content

Fix HTML Sanitizer method names in documentation #21215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3,404 commits into from

Conversation

OskarStark
Copy link
Contributor

Changed incorrect method names from allowed* to allow*:

  • allowedLinkSchemes() → allowLinkSchemes()
  • allowedLinkHosts() → allowLinkHosts()
  • allowedMediaSchemes() → allowMediaSchemes()
  • allowedMediaHosts() → allowMediaHosts()

These are the correct method names used in the HtmlSanitizerConfig class.

Fixes #21211

javiereguiluz and others added 30 commits May 23, 2025 09:55
…(MrYamous)

This PR was squashed before being merged into the 7.3 branch.

Discussion
----------

[Security] Add ability for voters to explain their vote

Fix #20658

Commits
-------

203c0f8 [Security] Add ability for voters to explain their vote
… (ker0x)

This PR was merged into the 7.3 branch.

Discussion
----------

[Workflow] Document custom workflow definition validator

Fix #20950

Commits
-------

e0fcd1c [Workflow] Document custom workflow definition validator
* 6.4:
  [Security] Fix type in `upgradePassword`
* 7.2:
  [Security] Fix type in `upgradePassword`
* 6.4:
  [Form] Remove link to abandoned collection package
  Update AsTaggedItem parameters name in the file value_resolver.rst
* 7.2:
  [Form] Remove link to abandoned collection package
  Update AsTaggedItem parameters name in the file value_resolver.rst
* 6.4:
  Mention that backward compatibility promise doesn't cover translations
* 7.2:
  Mention that backward compatibility promise doesn't cover translations
…latable behavior (javiereguiluz)

This PR was merged into the 7.2 branch.

Discussion
----------

[Translation] Don't mention the abandoned Doctrine Translatable behavior

Fixes #20855.

Last release is from 2021; last commit is from three years ago; it doesn't provide Symfony 7.x compatibility.

So, let's not mention it in 7.x docs anymore.

Commits
-------

310783b [Translation] Don't mention the abandoned Doctrine Translatable behavior
* 7.2:
  [Translation] Don't mention the abandoned Doctrine Translatable behavior
* 6.4:
  Minor tweaks
  Updating the web_server_configuration.rst File
  Fixed typo in event_dispatcher.rst
* 7.2:
  Minor tweaks
  Updating the web_server_configuration.rst File
  Fixed typo in event_dispatcher.rst
* 6.4:
  [HttpClient] Update the concurrent requests section
* 7.2:
  [HttpClient] Update the concurrent requests section
* 6.4:
  Remove the wrong XML config sample
  [Security] remove `plaintext` password hasher usage
* 7.2:
  Remove the wrong XML config sample
  [Security] remove `plaintext` password hasher usage
…ThomasLandauer)

This PR was merged into the 7.2 branch.

Discussion
----------

[Security] Stateless CSRF is enabled by default in 7.2

Page: https://symfony.com/doc/current/security/csrf.html#stateless-csrf-tokens

Info is taken from https://github.com/symfony/recipes/blob/main/symfony/form/7.2/config/packages/csrf.yaml

Commits
-------

faa30fc [Security] Stateless CSRF is enabled by default in 7.2
* 7.2:
  Minor tweak
  [Security] Stateless CSRF is enabled by default in 7.2
…e]` attribute (javiereguiluz)

This PR was merged into the 7.3 branch.

Discussion
----------

[FrameworkBundle] Enable controller service with `#[Route]` attribute

Fixes #20839.

This change required some updates in the article structure to better explain the three alternative solutions.

Commits
-------

2c33c36 [FrameworkBundle] Enable controller service with #[Route] attribute
* 6.4:
  Update uid.rst
* 7.2:
  Update uid.rst
…e handlers mean (finwe)

This PR was merged into the 7.2 branch.

Discussion
----------

[Messenger] Specify explicitly what a priority of message handlers mean

Commits
-------

5ca3039 Specify explicitly what a priority of message handlers mean
* 7.2:
  Reword
  Minor tweak
  Clarify the code flow a little bit more
  Specify explicitly what a priority of message handlers mean
javiereguiluz and others added 23 commits July 9, 2025 13:18
* 7.2:
  Minor tweaks
  Fix Mailer #21190 : Update documentation about `allowed_recipients` behaviour
* 6.4:
  Minor tweaks
  [WebLink] make use of avilable constant
* 7.2:
  Minor tweaks
  [WebLink] make use of avilable constant
* 6.4:
  Update symfony_cli.rst
* 7.2:
  Update symfony_cli.rst
* 6.4:
  [Serializer] type: align with interface signature for denormalize methods
* 7.2:
  [Serializer] type: align with interface signature for denormalize methods
* 6.4:
  list shortcuts of global CLI options as well
* 7.2:
  list shortcuts of global CLI options as well
* 6.4:
  Tweaks
  [AssetMapper] Missing 'importmap:remove' command
* 7.2:
  Tweaks
  [AssetMapper] Missing 'importmap:remove' command
Adds a clarification in the Lock component documentation about the the values to use for the env variable LOCK_DSN in order to activate the NullStore and the InMemoryStore.
…component NullStore and InMemoryStore (hmeknassi)

This PR was submitted for the 7.3 branch but it was merged into the 7.2 branch instead.

Discussion
----------

[Lock] Document what values to use to activate the Lock component NullStore and InMemoryStore

Adds a clarification in the Lock component documentation about the the values to use for the env variable LOCK_DSN in order to activate the NullStore and the InMemoryStore.

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `7.x` for features of unreleased versions).

-->

Commits
-------

0cb7c16 Update lock.rst
* 7.2:
  Tweaks
  Update lock.rst
* 6.4:
  Add tip about default value
* 7.2:
  Add tip about default value
* 6.4:
  bug #60745 [Scheduler] Add warning about comma-separated weekdays in PeriodicalTrigger
* 7.2:
  bug #60745 [Scheduler] Add warning about comma-separated weekdays in PeriodicalTrigger
…on (samnela)

This PR was merged into the 7.3 branch.

Discussion
----------

[Setup] Use the stable version to create a new application

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `7.x` for features of unreleased versions).

-->

Commits
-------

d1b52cb [Setup] Use the stable version to create a new application
Changed incorrect method names from `allowed*` to `allow*`:
- allowedLinkSchemes() → allowLinkSchemes()
- allowedLinkHosts() → allowLinkHosts()
- allowedMediaSchemes() → allowMediaSchemes()
- allowedMediaHosts() → allowMediaHosts()

These are the correct method names used in the HtmlSanitizerConfig class.

Fixes #21211
@OskarStark OskarStark requested a review from javiereguiluz July 18, 2025 07:32
@OskarStark OskarStark added the bug label Jul 18, 2025
@OskarStark OskarStark changed the base branch from 7.3 to 6.4 July 18, 2025 07:32
@OskarStark OskarStark requested a review from xabbuh as a code owner July 18, 2025 07:32
@OskarStark OskarStark closed this Jul 18, 2025
@OskarStark OskarStark deleted the html-sanitizer-method-names branch July 18, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML Sanitizer: Wrong Methodnames