[HtmlSanitizer] Fix method names #21216
Open
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed incorrect method names from `allowed*` to `allow*`: - allowedLinkSchemes() → allowLinkSchemes() - allowedLinkHosts() → allowLinkHosts() - allowedMediaSchemes() → allowMediaSchemes() - allowedMediaHosts() → allowMediaHosts() These are the correct method names used in the HtmlSanitizerConfig class. Fixes #21211
carsonbot
changed the title
OskarStark
changed the title
xabbuh
requested changes
Jul 18, 2025
| ->forceHttpsUrls(true) | ||
| // specifies the allowed URL schemes. If the URL has a different scheme, the | ||
| // attribute will be dropped | ||
| ->allowedLinkSchemes(['http', 'https', 'mailto']) | ||
| ->allowLinkSchemes(['http', 'https', 'mailto']) |
There was a problem hiding this comment.
For the DI configuration this is not the correct change, right?
| // specifies the allowed hosts, the attribute will be dropped if the | ||
| // URL contains a different host. Subdomains are allowed: e.g. the following | ||
| // config would also allow 'www.symfony.com', 'live.symfony.com', etc. | ||
| ->allowedLinkHosts(['symfony.com']) | ||
| ->allowLinkHosts(['symfony.com']) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed incorrect method names from
allowed*toallow*:These are the correct method names used in the HtmlSanitizerConfig class.
Fixes #21211