Skip to content

Commit 377a4bc

Browse files
committed
bug #3030 [React] Fix importmap to require react-dom/client (Kocal)
This PR was merged into the 2.x branch. Discussion ---------- [React] Fix importmap to require `react-dom/client` | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Following #2944, where the code changed from `import require$$0 from 'react-dom';` to `import { createRoot } from "react-dom/client";`. I forgot to update the `importmap` entry and add `react-dom/client` dependency. Commits ------- e41b4ed [React] Fix importmap to require `react-dom/client`
2 parents 9d62749 + e41b4ed commit 377a4bc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/React/assets/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"importmap": {
3636
"@hotwired/stimulus": "^3.0.0",
3737
"react": "^18.0",
38-
"react-dom": "^18.0",
38+
"react-dom/client": "^18.0",
3939
"@symfony/ux-react": "path:%PACKAGE%/dist/loader.js"
4040
}
4141
},

0 commit comments

Comments
 (0)