[LiveComponent] Fix methods visibility

[jakubtobiasz]

Hello,

Considering the ComponentWithFormTrait we can notice there are few private methods. In general, it's not messing anything up, but when we deal with projects like Sylius, it becomes problematic.

1. We have a FormComponent class using ComponentWithFormTrait.
2. We want to override some behavior or FormComponent by extending it. Let's call it a BetterFormComponent.
3. We need to add use ComponentWithFormTrait inside the BetterFormComponent as they're private (we cannot access them nor use e.g. formValues.

And yes, it can be easily done by a use statement; however (real case), I had an overridden trait's method in the parent class, and I couldn't find why my component is misbehaving compared to the original one :P.

So my suggestion is to mark all private methods in this trait as protected. It seems it wouldn't come with any side effects.

[Kocal]

Hey,

And yes, it can be easily done by a use statement; however (real case), I had an overridden trait's method in the parent class, and I couldn't find why my component is misbehaving compared to the original one :P.

I'm not 100% sure to understand, but the following code won't work as you want?

class FormComponent {
    use ComponentWithFormTrait { thePrivateMethod as protected; }
}

class BetterFormComponent extends FormComponent {
    // ...
}

[smnandre]

Hmm... as much as I understand your situation, this is exactly what private properties / methods ... protect us from.

Let me explain :)

Due to the Symfony BC promise, as long methods are private, we can do things (not all, but still have some freedom to recode things and / or improves them..)

But anything protected cannot be touched anymore in interface / behaviour / signature / etc.... for many years.

And this is not something we should risk.
... and not something we can do without opening BC for existing users :)

Symfony BC Promise detailed here: https://symfony.com/doc/current/contributing/code/bc.html

Maybe here we could imagine some new contract / interface ?

I'm the first one to dream about a lot of opening / extension points / composition in components, but we're really not enough for the moment :l