Skip to content

Commit a40a8a2

Browse files
committed
feature #1321 Drop support for Node.js 19 and 21 (Kocal)
This PR was merged into the main branch. Discussion ---------- Drop support for Node.js 19 and 21 Due to the `>=18.0.0` version constraint in `engines.node`, it means that we allows Node.js 19 and 21, but, we don't want that. Odds versions are supported only 6 months, it only helps library maintainers to update their library comptability with a new Node.js LTS-version. You can see on https://nodejs.org/fr/about/previous-releases that Node.js 19 is not present and Node.js 21 support has been stopped around ~may 2024. Some of our dependencies explicitly does not support explicitly Node.js 19/21, like css-minimizer-webpack-plugin that [I've tried to upgrade to v5](https://github.com/symfony/webpack-encore/actions/runs/10654621974/job/29531168804?pr=1320): ``` yarn install v1.22.22 [1/5] Validating package.json... [2/5] Resolving packages... [3/5] Fetching packages... error [email protected]: The engine "node" is incompatible with this module. Expected version "^18.12.0 || ^20.9.0 || >=22.0". Got "21.7.3" error Found incompatible module. info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. ``` Since we plan to release a new major version of Encore, it's the good moment. WDYT? Commits ------- 40ce3c9 Drop support for Node.js 19 and 21
2 parents 0bfcb2b + 40ce3c9 commit a40a8a2

File tree

5 files changed

+6
-4
lines changed

5 files changed

+6
-4
lines changed

.github/workflows/high-depends.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
fail-fast: false
1515
matrix:
1616
os: [ubuntu-latest, windows-2019]
17-
node-versions: ['18', '20', '21', '22']
17+
node-versions: ['18', '20', '22']
1818

1919
steps:
2020
- name: Checkout

.github/workflows/low-depends.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
fail-fast: false
1515
matrix:
1616
os: [ubuntu-latest, windows-2019]
17-
node-versions: ['18', '20', '21', '22']
17+
node-versions: ['18', '20', '22']
1818

1919
steps:
2020
- name: Checkout

.github/workflows/stable-tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
fail-fast: false
1515
matrix:
1616
os: [ubuntu-latest, windows-2019]
17-
node-versions: ['18', '20', '21', '22']
17+
node-versions: ['18', '20', '22']
1818

1919
steps:
2020
- name: Checkout

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ This is a new major version that contains several backwards-compatibility breaks
66

77
### BC Breaks
88

9+
* #1321 Drop support of Node.js 19 and 21 (@Kocal)
10+
911
* #1307 Drop `webpack-cli` 4 support, only `webpack-cli` ^5.1.4 is supported (@Kocal)
1012

1113
* #1308 Drop Vue 2 support (End-Of-Life), only Vue 3 is supported (@Kocal)

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"url": "https://github.com/symfony/webpack-encore/issues"
2424
},
2525
"engines": {
26-
"node": ">=18.0.0"
26+
"node": "^18.0.0 || ^20.0.0 || >=22.0"
2727
},
2828
"homepage": "https://github.com/symfony/webpack-encore",
2929
"dependencies": {

0 commit comments

Comments
 (0)