Merge pull request #8237 from systeminit/fix/clover/gcp/verbs

fix(clover): gcp pull http method from specs for creates

Author: sprutton1

bin/clover/src/pipelines/gcp/funcs/actions/create.ts

@@ -108,10 +108,12 @@ async function main(component: Input): Promise<Output> {
     url += (url.includes("?") ? "&" : "?") + queryParams.join("&");
   }
 
+  const httpMethod = insertApiPath.httpMethod || "POST";
+
   // Make the API request with retry logic
   const response = await siExec.withRetry(async () => {
     const resp = await fetch(url, {
-      method: "POST", // insert is always POST
+      method: httpMethod,
       headers: {
         "Authorization": `Bearer ${token}`,
         "Content-Type": "application/json",
@@ -121,7 +123,11 @@ async function main(component: Input): Promise<Output> {
 
     if (!resp.ok) {
       const errorText = await resp.text();
-      const error = new Error(`Unable to create resource; API returned ${resp.status} ${resp.statusText}: ${errorText}`) as any;
+      const error = new Error(`Unable to create resource;
+Called "${url}"
+API returned ${resp.status} ${resp.statusText}:
+${errorText}`
+      ) as any;
       error.status = resp.status;
       error.body = errorText;
       throw error;

bin/clover/src/pipelines/gcp/funcs/actions/delete.ts

@@ -112,7 +112,13 @@ async function main(component: Input): Promise<Output> {
       }
 
       const errorText = await resp.text();
-      const error = new Error(`Unable to delete resource; API returned ${resp.status} ${resp.statusText}: ${errorText}`) as any;
+
+      const error = new Error(`Unable to delete resource;
+Called "${url}"
+API returned ${resp.status} ${resp.statusText}:
+${errorText}`
+      ) as any;
+
       error.status = resp.status;
       error.body = errorText;
       throw error;

bin/clover/src/pipelines/gcp/funcs/actions/refresh.ts

@@ -109,7 +109,13 @@ async function main(component: Input): Promise<Output> {
       }
 
       const errorText = await resp.text();
-      const error = new Error(`Unable to refresh resource; API returned ${resp.status} ${resp.statusText}: ${errorText}`) as any;
+
+      const error = new Error(`Unable to refresh resource;
+Called "${url}"
+API returned ${resp.status} ${resp.statusText}:
+${errorText}`
+      ) as any;
+
       error.status = resp.status;
       error.body = errorText;
       throw error;

bin/clover/src/pipelines/gcp/funcs/actions/update.ts

@@ -159,7 +159,13 @@ async function main(component: Input): Promise<Output> {
 
     if (!resp.ok) {
       const errorText = await resp.text();
-      const error = new Error(`Unable to update resource; API returned ${resp.status} ${resp.statusText}: ${errorText}`) as any;
+
+      const error = new Error(`Unable to update resource;
+Called "${url}"
+API returned ${resp.status} ${resp.statusText}:
+${errorText}`
+      ) as any;
+
       error.status = resp.status;
       error.body = errorText;
       throw error;

bin/clover/src/pipelines/gcp/pipeline-steps/addDefaultProps.ts

@@ -78,6 +78,7 @@ export function addDefaultProps(specs: ExpandedPkgSpec[]): ExpandedPkgSpec[] {
       insertProp.data.hidden = true;
       insertProp.data.defaultValue = JSON.stringify({
         path: gcpSchema.methods.insert.path,
+        httpMethod: gcpSchema.methods.insert.httpMethod,
         parameterOrder: gcpSchema.methods.insert.parameterOrder,
       });
       extraProp.entries.push(insertProp);