Skip to content
This repository was archived by the owner on Mar 12, 2020. It is now read-only.

Commit 59fe535

Browse files
author
Eric Meyer
committed
Fixes merge-columns should not be case sensitive.
http://transparensee.jira.com/browse/DATATOOL-31
1 parent dfc26be commit 59fe535

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

src/main/java/com/t11e/discovery/datatool/SqlAction.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,17 @@
44
import java.util.Collections;
55
import java.util.HashSet;
66
import java.util.List;
7+
import java.util.ListIterator;
78
import java.util.Set;
89

910
import org.apache.commons.lang.StringUtils;
11+
import org.springframework.beans.factory.InitializingBean;
1012
import org.springframework.beans.factory.annotation.Required;
1113

1214
import com.t11e.discovery.datatool.column.MergeColumns;
1315

1416
public class SqlAction
17+
implements InitializingBean
1518
{
1619
private Set<String> filter = Collections.singleton("any");
1720
private String action;
@@ -24,6 +27,20 @@ public class SqlAction
2427
private Set<String> jsonColumnNames = Collections.emptySet();
2528
private boolean useLowerCaseColumnNames = true;
2629

30+
@Override
31+
public void afterPropertiesSet()
32+
throws Exception
33+
{
34+
if (useLowerCaseColumnNames && mergeColumns != null)
35+
{
36+
for (final ListIterator<MergeColumns> it = mergeColumns.listIterator(); it.hasNext();)
37+
{
38+
final MergeColumns merge = it.next();
39+
it.set(new MergeColumns(merge.getKeyColumn().toLowerCase(), merge.getValueColumn().toLowerCase()));
40+
}
41+
}
42+
}
43+
2744
public Set<String> getFilter()
2845
{
2946
return filter;

src/test/java/com/t11e/discovery/datatool/VerticalTableTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@
1414
<snapshot>
1515
<set-item idColumn="id">
1616
<query><![CDATA[
17-
SELECT data.id, name, value
17+
SELECT data.id, name as Name, value as Value
1818
FROM vertical_master_items master
1919
JOIN vertical_data data on data.id = master.id
2020
ORDER BY data.id, name, value
2121
]]></query>
22-
<merge-columns keyColumn="name" valueColumn="value"/>
22+
<merge-columns keyColumn="Name" valueColumn="Value"/>
2323
</set-item>
2424
<remove-item idColumn="id">
2525
<query><![CDATA[

0 commit comments

Comments
 (0)