fix: consume all entries from the channel to prevent blocking by the connection go-ldap#319

t2y · t2y · commit 72797107f94d · 2023-06-04T14:09:27.000+09:00
diff --git a/ldap_test.go b/ldap_test.go
@@ -401,6 +401,9 @@ func TestSearchWithChannelAndCancel(t *testing.T) {
 			cancel()
 		}
 	}
+	for range ch {
+		t.Log("Consume all entries from the channel to prevent blocking by the connection")
+	}
 	if len(srs) != cancelNum {
 		t.Errorf("Got entries %d, expected %d", len(srs), cancelNum)
 	}
diff --git a/v3/ldap_test.go b/v3/ldap_test.go
@@ -401,6 +401,9 @@ func TestSearchWithChannelAndCancel(t *testing.T) {
 			cancel()
 		}
 	}
+	for range ch {
+		t.Log("Consume all entries from the channel to prevent blocking by the connection")
+	}
 	if len(srs) != cancelNum {
 		t.Errorf("Got entries %d, expected %d", len(srs), cancelNum)
 	}

Original file line number	Diff line number	Diff line change
`@@ -401,6 +401,9 @@ func TestSearchWithChannelAndCancel(t *testing.T) {`
`401`	`401`	`cancel()`
`402`	`402`	`}`
`403`	`403`	`}`
	`404`	`+ for range ch {`
	`405`	`+ t.Log("Consume all entries from the channel to prevent blocking by the connection")`
	`406`	`+ }`
`404`	`407`	`if len(srs) != cancelNum {`
`405`	`408`	`t.Errorf("Got entries %d, expected %d", len(srs), cancelNum)`
`406`	`409`	`}`