chore: pytestify test_connection_ (#1650)

* chore: pytestify test_connection_

Embrace pytest's testing methodology in test_connection_

* chore: parameterize test

* chore: add type hints to tests

---------

Co-authored-by: Jordan Woods <[email protected]>

Author: jorwoods

test/test_connection_.py

@@ -1,34 +1,25 @@
-import unittest
 import tableauserverclient as TSC
 
+import pytest
 
-class DatasourceModelTests(unittest.TestCase):
-    def test_require_boolean_query_tag_fails(self):
-        conn = TSC.ConnectionItem()
-        conn._connection_type = "postgres"
-        with self.assertRaises(ValueError):
-            conn.query_tagging = "no"
 
-    def test_set_query_tag_normal_conn(self):
-        conn = TSC.ConnectionItem()
-        conn._connection_type = "postgres"
-        conn.query_tagging = True
-        self.assertEqual(conn.query_tagging, True)
+def test_require_boolean_query_tag_fails() -> None:
+    conn = TSC.ConnectionItem()
+    conn._connection_type = "postgres"
+    with pytest.raises(ValueError):
+        conn.query_tagging = "no"  # type: ignore[assignment]
 
-    def test_ignore_query_tag_for_hyper(self):
-        conn = TSC.ConnectionItem()
-        conn._connection_type = "hyper"
-        conn.query_tagging = True
-        self.assertEqual(conn.query_tagging, None)
 
-    def test_ignore_query_tag_for_teradata(self):
-        conn = TSC.ConnectionItem()
-        conn._connection_type = "teradata"
-        conn.query_tagging = True
-        self.assertEqual(conn.query_tagging, None)
+def test_set_query_tag_normal_conn() -> None:
+    conn = TSC.ConnectionItem()
+    conn._connection_type = "postgres"
+    conn.query_tagging = True
+    assert conn.query_tagging
 
-    def test_ignore_query_tag_for_snowflake(self):
-        conn = TSC.ConnectionItem()
-        conn._connection_type = "snowflake"
-        conn.query_tagging = True
-        self.assertEqual(conn.query_tagging, None)
+
+@pytest.mark.parametrize("conn_type", ["hyper", "teradata", "snowflake"])
+def test_ignore_query_tag(conn_type: str) -> None:
+    conn = TSC.ConnectionItem()
+    conn._connection_type = conn_type
+    conn.query_tagging = True
+    assert conn.query_tagging is None