-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode 1.91 breaks code actions #1018
Comments
Can you provide your vscode settings? |
Also, if possible, can you provide:
|
Settings:
|
Output:
|
Sorry for the late reply — I don't see anything in there that seems like it would cause things to break/hang. Especially given that the only code actions we have are quick fixes so afaik they can't be run on save anyway. If you disable intellisense does the problem go away? |
Yes, when I disable the plugin it goes away. Autocomplete doesn't work as well. |
We have any update about this topic? It's happening with me aswell |
Same |
@RiczCalixto @amhed Could either of you provide a reproduction for this? I've never seen this issue myself and I am not sure how it could happen in the first place. |
same |
I'm consistently getting this error as well. |
Same here |
@thecrypticace Yes. Seems that it breaks after trying to suggest something. With changes in code not related to tailwind classes it works good but after first className change it breaks save actions and don't work until extension restart. ![]() Edit: I discovered that it breaks when I'm working with tailwind-variants and classRegex setting. For className param in DOM element it works good.
Update 2 (Problem solved for me) My regex was different than tailwind-variant has currently in the documentation.
|
@Silon This was exactly the piece of information I needed! I've reproduced it in this case (well, so far once). I suspect that the "code actions" dialog might also be related to waiting for diagnostics — or maybe just a response at all. A runaway regex would absolutely do that because it completely locks up the process — we can't intercept it w/o doing some specialty stuff with worker threads. |
Just spent a small amount of time verifying. If you save a file that contains this text and the above original tailwind variants regex it freezes because of the catastrophic backtracking that happens when matching the regex:
We just merged a community contribution that added a {
"tailwindCSS.classFunctions": ["tv"],
} And IntelliSense will handle the rest. It only supports JS/TS/JSX/TSX right now but my hope is we'll expand it in the future to support other languages as needed. (but it does also work in I'm gonna close this one now since we've got a proper solution to not using the class regex in a number of cases and, as far as I can tell, that is the major cause of this. The only other potential cause I can think of is recursive symlinks freezing the process for a time during the initial file search which I've been working to address in #1242 (already released) and #1270 (still a work in progress) |
What version of VS Code are you using?
For example: v1.91
What version of Tailwind CSS IntelliSense are you using?
For example: v0.12.5
What version of Tailwind CSS are you using?
For example: v3.4.4
What package manager are you using?
For example: npm
What operating system are you using?
Ubuntu
It seems latest changes in vscode -
editor.codeActionsOnSave
break this plugin. Tailwind CSS Intellisense blocks code actions indefinitely. Log says:The text was updated successfully, but these errors were encountered: