Skip to content

Bug in DataSetTestExecutionListener at line 86 (Version 1.4.0) #52

Description

@jtchatchoua

private void checkDatas(TestContext testContext) throws Exception {
ExpectedDataSetConfiguration expectedConfiguration = getExpectedConfiguration(testContext);
if (expectedConfiguration != null) {
IDataSet expectedDataSet = expectedConfiguration.getDataSet();
for (String tableName : expectedDataSet.getTableNames()) {
IDataSet dataSet = dataReader.execute(testContext.getApplicationContext(), getExpectedConfiguration(testContext), tableName);
String[] columnsToIgnore = expectedConfiguration.getColumnsToIgnore();
if (columnsToIgnore == null || columnsToIgnore.length == 0) {

              `Assertion.assertEquals(expectedDataSet, dataSet);`

// When the dataset has more than one table, test fails when compare tableNames length. I think the code here should be
Assertion.assertEquals(expectedDataSet.getTable(tableName), dataSet.getTable(tableName));

            } else {
                Assertion.assertEqualsIgnoreCols(expectedDataSet, dataSet, tableName, columnsToIgnore);
            }
        }
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions