-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to specify visualCrop: (CropShape) -> CropShape = { it } #25
Comments
Hello @qavan! To show the original picture in social media, it's better to save two versions, one cropped image for the small circular profile picture, and one original image without any cropping, which you will display when the user wants to view the full picture. |
Yeah, visually same, BUT your result is rect image with black background out of circle. I want to have circle visual crop with fully rect image, without black background out of circle. This is why I want to introduce |
It depends |
@qavan Could you please attach a result bitmap, how it should look like after cropping, without the black background around the circle? |
@qavan Did I understand correctly, that the result image should have everything inside the cropping grid / square, but show a circular shape while cropping? |
@tamimattafi yes! Exactly! |
@qavan I understand now, thank you. I think adding such a feature isn't hard, but I am not sure if I will find time in the upcoming days, since I'm on vacation. Please feel free to make a pull request from 0.2.0 branch. |
I'd also be interested in this particular use-case. |
Nice lib❤️
But helpful to have argument like
visualCrop: (CropShape) -> CropShape = { it }
to have "visual crop" of crop area.One of usecases: cropping image for avatar in social media, when usually you see circle shaped image, but also can view full image(rect).
The text was updated successfully, but these errors were encountered: