Skip to content

chore(ci): increase build timeout and disable audit for cross builds#1350

Merged
stringhandler merged 3 commits intotari-project:developmentfrom
leet4tari:build-bins-leet-timeout
Mar 27, 2025
Merged

chore(ci): increase build timeout and disable audit for cross builds#1350
stringhandler merged 3 commits intotari-project:developmentfrom
leet4tari:build-bins-leet-timeout

Conversation

@leet4tari
Copy link
Contributor

@leet4tari leet4tari commented Mar 26, 2025

Description
Increase build timeout
Disable audit for cross builds

Motivation and Context
Extend long build timeout
Don't run audit on cross builds as they don't have audit records.

Summary by CodeRabbit

  • Chores
    • Extended the build process duration to accommodate more complex or larger releases.
    • Refined the audit step execution to ensure it runs reliably under the appropriate conditions.

@leet4tari leet4tari requested a review from a team as a code owner March 26, 2025 09:14
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 26, 2025

Walkthrough

This pull request updates the build process configuration in the .github/workflows/build_binaries.yml file. It increases the timeout for the "Build release binaries" step from 30 minutes to 60 minutes and removes a comment from the condition in the "Audit tree and feedback for binaries" step while retaining its condition (! matrix.builds.cross). These adjustments affect execution timing and control flow without modifying the build logic.

Changes

File Change Summary
.github/workflows/build_binaries.yml - Increased build timeout from 30 to 60 minutes.
- Removed comment in the audit step while retaining the condition ! matrix.builds.cross.

Sequence Diagram(s)

sequenceDiagram
    participant Runner as GitHub Runner
    participant Build as Build Release Binaries Step
    participant Audit as Audit Tree and Feedback Step
    Runner->>Build: Start build process (timeout: 60 mins)
    Build-->>Runner: Build process completed
    alt If !matrix.builds.cross is true
        Runner->>Audit: Execute audit step
    else
        Note over Runner,Audit: Skip audit step
    end
Loading

Possibly related PRs

Suggested labels

P-reviews_required

Suggested reviewers

  • sdbondi

Poem

I'm just a bunny, hopping with glee,
Celebrating changes in our YAML spree! 🐇
Timeout stretched from short to long,
Audit steps now sing a clearer song.
With whiskers twitching in code delight,
Our build process hops into the light!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3f8df7 and a0260d7.

📒 Files selected for processing (1)
  • .github/workflows/build_binaries.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: check stable
  • GitHub Check: check nightly
  • GitHub Check: test
  • GitHub Check: clippy
🔇 Additional comments (2)
.github/workflows/build_binaries.yml (2)

315-316: Increased Build Timeout is properly configured.
The build timeout for the "Build release binaries" step has been increased to 60 minutes, which aligns with the objective of accommodating longer build processes. This adjustment should help prevent premature build terminations.


594-600: Audit Step Condition Effectively Disables Audit for Cross Builds.
The condition if: ${{ ( ! matrix.builds.cross ) }} now ensures that the "Audit tree and feedback for binaries" step is skipped when a cross build is in progress, fulfilling the PR objective. Consider adding a short in-line comment explaining this decision to assist future maintainers.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

Test Results (CI)

656 tests  ±0   656 ✅ ±0   30m 24s ⏱️ -50s
 55 suites ±0     0 💤 ±0 
  2 files   ±0     0 ❌ ±0 
  1 errors

For more details on these parsing errors, see this check.

Results for commit a0260d7. ± Comparison against base commit c3f8df7.

@stringhandler stringhandler disabled auto-merge March 27, 2025 13:03
@stringhandler stringhandler merged commit 9772182 into tari-project:development Mar 27, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants