Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not work with path style requests #12

Open
danielduduta opened this issue Oct 28, 2014 · 1 comment
Open

does not work with path style requests #12

danielduduta opened this issue Oct 28, 2014 · 1 comment

Comments

@danielduduta
Copy link

Hi,
It doesn't seem to work with path-style requests: e.g.
https://s3-eu-west-1.amazonaws.com/my_bucket.name/a1_v1.jpg

It seems to think 's3-eu-west' is the bucket.

@tax
Copy link
Owner

tax commented Nov 4, 2014

Hi @danielduduta ,

Thanks for reporting this, sorry for the late reply I'm fairly busy but I will try to create a fix for this.
Are you using this url for a put request or for another type of request?

Not sure what the best way is to detect path-style urls maybe via an extra param path_style to the constructor:

S3Auth(self, access_key, secret_key, service_url=None, path_style=False)

Do you have any thoughts or suggestions on this?

hackalyze pushed a commit to hackalyze/python-requests-aws that referenced this issue Mar 15, 2018
…dy supported virtual-hosted-style URL format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants