Add benchmarks project and enable central package mgmt

tazayan · tazayan · commit bd8360591585 · 2026-01-03T23:13:38.000-06:00
Introduce PropertyFlex.Benchmarks project with initial setup and placeholder benchmark classes. Enable Central Package Management via Directory.Packages.props and update all projects to use it. Disable analyzers and warnings-as-errors for test and benchmark projects. Refactor and expand ValueContainerTests for clarity, coverage, and use of factory methods. Expose internals to test and benchmark projects. Update solution file to include new items.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -4,5 +4,13 @@
 	<ImplicitUsings>enable</ImplicitUsings>
 	<Nullable>enable</Nullable>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+	<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
   </PropertyGroup>
+	<!-- Disable analyzers for test and benchmark projects -->
+	<PropertyGroup Condition="$(MSBuildProjectName.EndsWith('.Tests')) Or 
+                            $(MSBuildProjectName.EndsWith('.Benchmarks'))">
+		<EnableNETAnalyzers>false</EnableNETAnalyzers>
+		<EnforceCodeStyleInBuild>false</EnforceCodeStyleInBuild>
+		<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
+	</PropertyGroup>
 </Project>
diff --git a/Directory.Packages.props b/Directory.Packages.props
@@ -0,0 +1,13 @@
+<Project>
+  <ItemGroup>
+    <!-- Testing -->
+    <PackageVersion Include="xunit.v3" Version="1.1.0" />
+    <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.0" />
+    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.0" />
+    <PackageVersion Include="FluentAssertions" Version="8.3.0" />
+    <PackageVersion Include="coverlet.collector" Version="6.0.4" />
+
+    <!-- Benchmarking -->
+    <PackageVersion Include="BenchmarkDotNet" Version="0.14.0" />
+  </ItemGroup>
+</Project>
diff --git a/PropertyFlex.slnx b/PropertyFlex.slnx
@@ -2,7 +2,9 @@
   <Folder Name="/SolutionItems/">
     <File Path=".editorconfig" />
     <File Path="Directory.Build.props" />
+    <File Path="Directory.Packages.props" />
   </Folder>
+  <Project Path="benchmarks/PropertyFlex.Benchmarks/PropertyFlex.Benchmarks.csproj" Id="248b2543-a7ee-4d8e-ad80-53595df157ca" />
   <Project Path="src/PropertyFlex/PropertyFlex.csproj" />
   <Project Path="tests/PropertyFlex.Tests/PropertyFlex.Tests.csproj" />
 </Solution>
diff --git a/benchmarks/PropertyFlex.Benchmarks/Benchmarks/FlexBenchmarks.cs b/benchmarks/PropertyFlex.Benchmarks/Benchmarks/FlexBenchmarks.cs
@@ -0,0 +1,5 @@
+﻿namespace PropertyFlex.Benchmarks;
+
+internal sealed class FlexBenchmarks
+{
+}
diff --git a/benchmarks/PropertyFlex.Benchmarks/Benchmarks/UnionBenchmarks.cs b/benchmarks/PropertyFlex.Benchmarks/Benchmarks/UnionBenchmarks.cs
@@ -0,0 +1,5 @@
+﻿namespace PropertyFlex.Benchmarks;
+
+internal sealed class UnionBenchmarks
+{
+}
diff --git a/benchmarks/PropertyFlex.Benchmarks/Benchmarks/ValueContainerBenchmarks.cs b/benchmarks/PropertyFlex.Benchmarks/Benchmarks/ValueContainerBenchmarks.cs
@@ -0,0 +1,5 @@
+﻿namespace PropertyFlex.Benchmarks;
+
+internal sealed class ValueContainerBenchmarks
+{
+}
diff --git a/benchmarks/PropertyFlex.Benchmarks/Program.cs b/benchmarks/PropertyFlex.Benchmarks/Program.cs
@@ -0,0 +1,8 @@
+﻿namespace PropertyFlex.Benchmarks;
+
+internal sealed class Program
+{
+    public static void Main(string[] args)
+    {
+    }
+}
diff --git a/benchmarks/PropertyFlex.Benchmarks/PropertyFlex.Benchmarks.csproj b/benchmarks/PropertyFlex.Benchmarks/PropertyFlex.Benchmarks.csproj
@@ -0,0 +1,15 @@
+﻿<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="BenchmarkDotNet" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <ProjectReference Include="..\..\src\PropertyFlex\PropertyFlex.csproj" />
+  </ItemGroup>
+
+</Project>
diff --git a/src/PropertyFlex/PropertyFlex.csproj b/src/PropertyFlex/PropertyFlex.csproj
@@ -4,4 +4,9 @@
 	<DefaultNamespace>PropertyFlexLib</DefaultNamespace>
   </PropertyGroup>
 
+  <ItemGroup>
+    <InternalsVisibleTo Include="PropertyFlex.Tests" />
+    <InternalsVisibleTo Include="PropertyFlex.Benchmarks" />
+  </ItemGroup>
+
 </Project>
diff --git a/tests/PropertyFlex.Tests/PropertyFlex.Tests.csproj b/tests/PropertyFlex.Tests/PropertyFlex.Tests.csproj
@@ -10,20 +10,20 @@
 
   <ItemGroup>
     <!-- XUnit v3 - Latest version with modern features -->
-    <PackageReference Include="xunit.v3" Version="1.*" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="3.*">
+    <PackageReference Include="xunit.v3" />
+    <PackageReference Include="xunit.runner.visualstudio">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
     
     <!-- Required for running tests -->
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.*" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" />
     
     <!-- FluentAssertions for more readable and expressive assertions -->
-    <PackageReference Include="FluentAssertions" Version="8.*" />
+    <PackageReference Include="FluentAssertions" />
     
     <!-- Coverlet for code coverage -->
-    <PackageReference Include="coverlet.collector" Version="6.*">
+    <PackageReference Include="coverlet.collector">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
diff --git a/tests/PropertyFlex.Tests/ValueContainerTests.cs b/tests/PropertyFlex.Tests/ValueContainerTests.cs
@@ -1,94 +1,94 @@
 ﻿namespace PropertyFlex.Tests;
 
 /// <summary>
-/// Unit tests for <see cref="ValueContainer"/> ref struct.
+/// Unit tests for <see cref="ValueContainer"/> struct.
 /// </summary>
 public class ValueContainerTests
 {
     [Fact]
-    public void ValueContainer_WithNoneType_ShouldNotBeValueType()
+    public void ValueContainer_Default_ShouldNotBeValueType()
     {
         // Arrange & Act
-        var container = new ValueContainer(null, (0L, 0L), ValueContainerType.None);
+        var container = default(ValueContainer);
 
         // Assert
         container.IsValueType.Should().BeFalse();
     }
 
     [Fact]
-    public void ValueContainer_WithValueType_ShouldBeValueType()
+    public void ValueContainer_WithPrimitiveValue_ShouldBeValueType()
     {
         // Arrange & Act
-        var container = new ValueContainer(null, (42L, 0L), ValueContainerType.ValueType);
+        var container = ValueContainer.FromLong(42L);
 
         // Assert
         container.IsValueType.Should().BeTrue();
     }
 
     [Fact]
-    public void ValueContainer_WithReferenceType_ShouldNotBeValueType()
+    public void ValueContainer_WithReferenceValue_ShouldNotBeValueType()
     {
         // Arrange
         var referenceValue = "test string";
 
         // Act
-        var container = new ValueContainer(referenceValue, (0L, 0L), ValueContainerType.ReferenceType);
+        var container = ValueContainer.FromReference(referenceValue);
 
         // Assert
         container.IsValueType.Should().BeFalse();
     }
 
     [Fact]
-    public void ValueContainer_Equals_SameNoneType_ShouldBeEqual()
+    public void ValueContainer_Equals_SameDefaultValue_ShouldBeEqual()
     {
         // Arrange
-        var container1 = new ValueContainer(null, (0L, 0L), ValueContainerType.None);
-        var container2 = new ValueContainer(null, (0L, 0L), ValueContainerType.None);
+        var container1 = default(ValueContainer);
+        var container2 = default(ValueContainer);
 
         // Assert
         container1.Equals(container2).Should().BeTrue();
     }
 
     [Fact]
-    public void ValueContainer_Equals_SameValueType_ShouldBeEqual()
+    public void ValueContainer_Equals_SamePrimitiveValue_ShouldBeEqual()
     {
         // Arrange
-        var container1 = new ValueContainer(null, (42L, 100L), ValueContainerType.ValueType);
-        var container2 = new ValueContainer(null, (42L, 100L), ValueContainerType.ValueType);
+        var container1 = ValueContainer.FromLong(42L);
+        var container2 = ValueContainer.FromLong(42L);
 
         // Assert
         container1.Equals(container2).Should().BeTrue();
     }
 
     [Fact]
-    public void ValueContainer_Equals_DifferentValueType_ShouldNotBeEqual()
+    public void ValueContainer_Equals_DifferentPrimitiveValue_ShouldNotBeEqual()
     {
         // Arrange
-        var container1 = new ValueContainer(null, (42L, 100L), ValueContainerType.ValueType);
-        var container2 = new ValueContainer(null, (43L, 100L), ValueContainerType.ValueType);
+        var container1 = ValueContainer.FromLong(42L);
+        var container2 = ValueContainer.FromLong(43L);
 
         // Assert
         container1.Equals(container2).Should().BeFalse();
     }
 
     [Fact]
-    public void ValueContainer_Equals_SameReferenceType_ShouldBeEqual()
+    public void ValueContainer_Equals_SameReferenceValue_ShouldBeEqual()
     {
         // Arrange
         var sharedReference = "shared";
-        var container1 = new ValueContainer(sharedReference, (0L, 0L), ValueContainerType.ReferenceType);
-        var container2 = new ValueContainer(sharedReference, (0L, 0L), ValueContainerType.ReferenceType);
+        var container1 = ValueContainer.FromReference(sharedReference);
+        var container2 = ValueContainer.FromReference(sharedReference);
 
         // Assert
         container1.Equals(container2).Should().BeTrue();
     }
 
     [Fact]
-    public void ValueContainer_Equals_DifferentReferenceType_ShouldNotBeEqual()
+    public void ValueContainer_Equals_DifferentReferenceValue_ShouldNotBeEqual()
     {
         // Arrange
-        var container1 = new ValueContainer("value1", (0L, 0L), ValueContainerType.ReferenceType);
-        var container2 = new ValueContainer("value2", (0L, 0L), ValueContainerType.ReferenceType);
+        var container1 = ValueContainer.FromReference("value1");
+        var container2 = ValueContainer.FromReference("value2");
 
         // Assert
         container1.Equals(container2).Should().BeFalse();
@@ -98,41 +98,126 @@ public void ValueContainer_Equals_DifferentReferenceType_ShouldNotBeEqual()
     public void ValueContainer_Equals_DifferentTypes_ShouldNotBeEqual()
     {
         // Arrange
-        var container1 = new ValueContainer(null, (42L, 0L), ValueContainerType.ValueType);
-        var container2 = new ValueContainer("test", (42L, 0L), ValueContainerType.ReferenceType);
+        var container1 = ValueContainer.FromLong(42L);
+        var container2 = ValueContainer.FromReference("test");
 
         // Assert
         container1.Equals(container2).Should().BeFalse();
     }
 
     [Fact]
-    public void ValueContainer_GetHashCode_SameValueType_ShouldBeSame()
+    public void ValueContainer_GetHashCode_SamePrimitiveValue_ShouldBeSame()
     {
         // Arrange
-        var container1 = new ValueContainer(null, (42L, 100L), ValueContainerType.ValueType);
-        var container2 = new ValueContainer(null, (42L, 100L), ValueContainerType.ValueType);
+        var container1 = ValueContainer.FromLong(42L);
+        var container2 = ValueContainer.FromLong(42L);
 
         // Assert
         container1.GetHashCode().Should().Be(container2.GetHashCode());
     }
 
     [Fact]
-    public void ValueContainer_GetHashCode_NoneType_ShouldBeZero()
+    public void ValueContainer_GetHashCode_DefaultValue_ShouldBeZero()
     {
         // Arrange
-        var container = new ValueContainer(null, (0L, 0L), ValueContainerType.None);
+        var container = default(ValueContainer);
 
         // Assert
         container.GetHashCode().Should().Be(0);
     }
 
     [Fact]
-    public void ValueContainer_GetHashCode_ReferenceType_WithNull_ShouldBeZero()
+    public void ValueContainer_GetHashCode_ReferenceValue_WithNull_ShouldNotThrow()
     {
         // Arrange
-        var container = new ValueContainer(null, (0L, 0L), ValueContainerType.ReferenceType);
+        var container = ValueContainer.FromReference(null);
+
+        // Act
+        var hashCode = container.GetHashCode();
+
+        // Assert - should not throw and return a consistent value
+        hashCode.Should().Be(ValueContainer.FromReference(null).GetHashCode());
+    }
+
+    [Fact]
+    public void ValueContainer_FromDouble_ShouldBeValueType()
+    {
+        // Arrange & Act
+        var container = ValueContainer.FromDouble(3.14);
 
         // Assert
-        container.GetHashCode().Should().Be(0);
+        container.IsValueType.Should().BeTrue();
+    }
+
+    [Fact]
+    public void ValueContainer_FromInt_ShouldBeValueType()
+    {
+        // Arrange & Act
+        var container = ValueContainer.FromInt(123);
+
+        // Assert
+        container.IsValueType.Should().BeTrue();
+    }
+
+    [Fact]
+    public void ValueContainer_FromBool_ShouldBeValueType()
+    {
+        // Arrange & Act
+        var container = ValueContainer.FromBool(true);
+
+        // Assert
+        container.IsValueType.Should().BeTrue();
+    }
+
+    [Fact]
+    public void ValueContainer_FromGuid_ShouldBeValueType()
+    {
+        // Arrange & Act
+        var container = ValueContainer.FromGuid(Guid.NewGuid());
+
+        // Assert
+        container.IsValueType.Should().BeTrue();
+    }
+
+    [Fact]
+    public void ValueContainer_FromDateTime_ShouldBeValueType()
+    {
+        // Arrange & Act
+        var container = ValueContainer.FromDateTime(DateTime.Now);
+
+        // Assert
+        container.IsValueType.Should().BeTrue();
+    }
+
+    [Fact]
+    public void ValueContainer_FromDecimal_ShouldBeValueType()
+    {
+        // Arrange & Act
+        var container = ValueContainer.FromDecimal(123.45m);
+
+        // Assert
+        container.IsValueType.Should().BeTrue();
+    }
+
+    [Fact]
+    public void ValueContainer_EqualityOperator_SameValue_ShouldBeTrue()
+    {
+        // Arrange
+        var container1 = ValueContainer.FromInt(42);
+        var container2 = ValueContainer.FromInt(42);
+
+        // Assert
+        (container1 == container2).Should().BeTrue();
+    }
+
+    [Fact]
+    public void ValueContainer_InequalityOperator_DifferentValue_ShouldBeTrue()
+    {
+        // Arrange
+        var container1 = ValueContainer.FromInt(42);
+        var container2 = ValueContainer.FromInt(43);
+
+        // Assert
+        (container1 != container2).Should().BeTrue();
     }
 }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +namespace PropertyFlex.Benchmarks;
++
 +internal sealed class FlexBenchmarks
 +{
 +}