Skip to content

Commit 8353170

Browse files
committed
util: Use tasklib.__version__ to determine module version
Importing pkg_resources module is notoriously slow, see [1,2]. Tasklib module now provides __version__ attribute for an easy method of version checking. [1] pypa/setuptools#510 [2] pypa/setuptools#926
1 parent 5032d0d commit 8353170

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

taskwiki/util.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,13 @@
33
from distutils.version import LooseVersion
44

55
import contextlib
6-
import pkg_resources
76
import os
87
import random
98
import sys
109
import vim # pylint: disable=F0401
1110

11+
import tasklib
12+
1213
from taskwiki.errors import TaskWikiException
1314
from taskwiki import regexp
1415

@@ -371,8 +372,8 @@ def enforce_dependencies(cache):
371372
TASKWARRIOR_VERSION = '2.4.0'
372373

373374
# Check tasklib version
374-
tasklib_module_info = pkg_resources.get_distribution('tasklib')
375-
tasklib_installed_version = LooseVersion(tasklib_module_info.version)
375+
tasklib_module_version = getattr(tasklib, '__version__', '2.2.0')
376+
tasklib_installed_version = LooseVersion(tasklib_module_version)
376377
tasklib_required_version = LooseVersion(TASKLIB_VERSION)
377378

378379
if tasklib_required_version > tasklib_installed_version:

0 commit comments

Comments
 (0)