Rename CreateNonEnumerableDataPropertyOrThrow

[nicolo-ribaudo]

That AO never throws: https://tc39.es/ecma262/#sec-createnonenumerabledatapropertyorthrow

This might be a good issue for new (human) contributors, but please wait until after #3000 is merged before opening a PR.

[linusg]

Alternatively we could also keep the name and instead update the AO to match other OrThrow variants and move the no-throw assertion to the call site.

[nicolo-ribaudo]

You mean removing the assertion in step 1?

[linusg]

Correct:

1. Assert: obj is an ordinary, extensible object with no non-configurable properties.
2. Let newDesc be the PropertyDescriptor { [[Value]]: value, [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true }.
3. Perform ! DefinePropertyOrThrow(obj, propertyKey, newDesc).
4. Return unused.

⬇️

1. Let newDesc be the PropertyDescriptor { [[Value]]: value, [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true }.
2. Perform ? DefinePropertyOrThrow(obj, propertyKey, newDesc).
3. Return unused.

[bakkot]

See previously although we never actually did it.

My vote is InfalliblyCreateDataProperty.

Ecmarkup will complain (I think rightly) if you make it fallible but then every callsite asserts that it doesn't actually throw at that callsite.