Increase TypedArray/ArrayBuffer coverage for Atomics

Author: gibson042

harness/testTypedArray.js

@@ -322,26 +322,46 @@ var nonAtomicsFriendlyTypedArrayConstructors = floatArrayConstructors.concat([Ui
  *
  * @param {typedArrayConstructorCallback} f - the function to call for each typed array constructor.
  * @param {Array} selected - An optional Array with filtered typed arrays
+ * @param {typedArrayArgFactoryFeature[]} [includeArgFactories] - for selecting
+ *   initial constructor argument factory functions, rather than starting with
+ *   all argument factories
+ * @param {typedArrayArgFactoryFeature[]} [excludeArgFactories] - for excluding
+ *   constructor argument factory functions, after an initial selection
  */
-function testWithNonAtomicsFriendlyTypedArrayConstructors(f) {
-  testWithTypedArrayConstructors(f, nonAtomicsFriendlyTypedArrayConstructors);
+function testWithNonAtomicsFriendlyTypedArrayConstructors(f, includeArgFactories, excludeArgFactories) {
+  testWithAllTypedArrayConstructors(
+    f,
+    nonAtomicsFriendlyTypedArrayConstructors,
+    includeArgFactories,
+    excludeArgFactories
+  );
 }
 
 /**
  * Calls the provided function for every "Atomics Friendly" typed array constructor.
  *
  * @param {typedArrayConstructorCallback} f - the function to call for each typed array constructor.
  * @param {Array} selected - An optional Array with filtered typed arrays
+ * @param {typedArrayArgFactoryFeature[]} [includeArgFactories] - for selecting
+ *   initial constructor argument factory functions, rather than starting with
+ *   all argument factories
+ * @param {typedArrayArgFactoryFeature[]} [excludeArgFactories] - for excluding
+ *   constructor argument factory functions, after an initial selection
  */
-function testWithAtomicsFriendlyTypedArrayConstructors(f) {
-  testWithTypedArrayConstructors(f, [
-    Int32Array,
-    Int16Array,
-    Int8Array,
-    Uint32Array,
-    Uint16Array,
-    Uint8Array,
-  ]);
+function testWithAtomicsFriendlyTypedArrayConstructors(f, includeArgFactories, excludeArgFactories) {
+  testWithAllTypedArrayConstructors(
+    f,
+    [
+      Int32Array,
+      Int16Array,
+      Int8Array,
+      Uint32Array,
+      Uint16Array,
+      Uint8Array,
+    ],
+    includeArgFactories,
+    excludeArgFactories
+  );
 }
 
 /**
@@ -368,7 +388,7 @@ function testTypedArrayConversions(byteConversionValues, fn) {
       }
       fn(TA, value, exp, initial);
     });
-  });
+  }, null, ["passthrough"]);
 }
 
 /**

test/built-ins/Atomics/add/bad-range.js

@@ -19,4 +19,4 @@ testWithTypedArrayConstructors(function(TA) {
       Atomics.add(view, IdxGen(view), 10);
     });
   });
-}, views);
+}, views, ["passthrough"]);

test/built-ins/Atomics/add/bigint/non-shared-bufferdata.js

@@ -7,9 +7,9 @@ description: >
 includes: [testTypedArray.js]
 features: [ArrayBuffer, Atomics, BigInt, TypedArray]
 ---*/
-testWithBigIntTypedArrayConstructors(TA => {
-  const buffer = new ArrayBuffer(TA.BYTES_PER_ELEMENT * 4);
+testWithBigIntTypedArrayConstructors((TA, makeCtorArg) => {
+  const buffer = makeCtorArg(4);
   const view = new TA(buffer);
   assert.sameValue(Atomics.add(view, 0, 1n), 0n, 'Atomics.add(view, 0, 1n) returns 0n');
   assert.sameValue(Atomics.load(view, 0), 1n, 'Atomics.load(view, 0) returns 1n');
-}, null, ["passthrough"]);
+}, null, ["arraybuffer"], ["immutable"]);

test/built-ins/Atomics/add/good-views.js

@@ -51,4 +51,4 @@ testWithTypedArrayConstructors(function(TA) {
     Atomics.store(view, Idx, 37);
     assert.sameValue(Atomics.add(view, Idx, 0), 37, 'Atomics.add(view, Idx, 0) returns 37');
   });
-}, views);
+}, views, ["passthrough"]);

test/built-ins/Atomics/add/non-shared-bufferdata.js

@@ -8,11 +8,9 @@ description: >
 includes: [testTypedArray.js]
 features: [ArrayBuffer, Atomics, TypedArray]
 ---*/
-testWithAtomicsFriendlyTypedArrayConstructors(TA => {
-  const view = new TA(
-    new ArrayBuffer(TA.BYTES_PER_ELEMENT * 4)
-  );
+testWithAtomicsFriendlyTypedArrayConstructors((TA, makeCtorArg) => {
+  const view = new TA(makeCtorArg(4));
 
   assert.sameValue(Atomics.add(view, 0, 1), 0, 'Atomics.add(view, 0, 1) returns 0');
   assert.sameValue(Atomics.load(view, 0), 1, 'Atomics.load(view, 0) returns 1');
-}, null, ["passthrough"]);
+}, ["arraybuffer"], ["immutable"]);

test/built-ins/Atomics/add/non-shared-int-views-throws.js

@@ -8,11 +8,11 @@ description: >
 includes: [testTypedArray.js]
 features: [ArrayBuffer, Atomics, TypedArray]
 ---*/
-testWithNonAtomicsFriendlyTypedArrayConstructors(TA => {
-  const buffer = new ArrayBuffer(TA.BYTES_PER_ELEMENT * 4);
+testWithNonAtomicsFriendlyTypedArrayConstructors((TA, makeCtorArg) => {
+  const buffer = makeCtorArg(4);
   const view = new TA(buffer);
 
   assert.throws(TypeError, function() {
     Atomics.add(view, 0, 1);
   }, `Atomics.add(new ${TA.name}(buffer), 0, 1) throws TypeError`);
-}, null, ["passthrough"]);
+}, ["arraybuffer"]);

test/built-ins/Atomics/and/bad-range.js

@@ -19,4 +19,4 @@ testWithTypedArrayConstructors(function(TA) {
       Atomics.and(view, IdxGen(view), 10);
     });
   });
-}, views);
+}, views, ["passthrough"]);

test/built-ins/Atomics/and/bigint/non-shared-bufferdata.js

@@ -7,9 +7,9 @@ description: >
 includes: [testTypedArray.js]
 features: [ArrayBuffer, Atomics, BigInt, TypedArray]
 ---*/
-testWithBigIntTypedArrayConstructors(TA => {
-  const buffer = new ArrayBuffer(TA.BYTES_PER_ELEMENT * 4);
+testWithBigIntTypedArrayConstructors((TA, makeCtorArg) => {
+  const buffer = makeCtorArg(4);
   const view = new TA(buffer);
   assert.sameValue(Atomics.and(view, 0, 1n), 0n, 'Atomics.and(view, 0, 1n) returns 0n');
   assert.sameValue(Atomics.load(view, 0), 0n, 'Atomics.load(view, 0) returns 0n');
-}, null, ["passthrough"]);
+}, null, ["arraybuffer"], ["immutable"]);

test/built-ins/Atomics/and/good-views.js

@@ -66,4 +66,4 @@ testWithTypedArrayConstructors(function(TA) {
     Atomics.store(view, Idx, 37);
     assert.sameValue(Atomics.and(view, Idx, 0), 37, 'Atomics.and(view, Idx, 0) returns 37');
   });
-}, views);
+}, views, ["passthrough"]);

test/built-ins/Atomics/and/non-shared-bufferdata.js

@@ -8,11 +8,9 @@ description: >
 includes: [testTypedArray.js]
 features: [ArrayBuffer, Atomics, TypedArray]
 ---*/
-testWithAtomicsFriendlyTypedArrayConstructors(TA => {
-  const view = new TA(
-    new ArrayBuffer(TA.BYTES_PER_ELEMENT * 4)
-  );
+testWithAtomicsFriendlyTypedArrayConstructors((TA, makeCtorArg) => {
+  const view = new TA(makeCtorArg(4));
 
   assert.sameValue(Atomics.and(view, 0, 1), 0, 'Atomics.and(view, 0, 1) returns 0');
   assert.sameValue(Atomics.load(view, 0), 0, 'Atomics.load(view, 0) returns 0');
-}, null, ["passthrough"]);
+}, ["arraybuffer"], ["immutable"]);